Title: [115833] trunk/Tools
- Revision
- 115833
- Author
- [email protected]
- Date
- 2012-05-02 08:13:35 -0700 (Wed, 02 May 2012)
Log Message
webkitpy: Fix sys.platform check in find_files_unittest.
https://bugs.webkit.org/show_bug.cgi?id=85339
Reviewed by Ryosuke Niwa.
Follow-up to r101618 -- 'win' is not a valid sys.platform value,
'win32' should be used instead. The check always returned false
due to this, so assert_normalize() was never called.
* Scripts/webkitpy/common/find_files_unittest.py:
(TestWinNormalize.test_win): Add the missing import for the
FileSystem class and fix the sys.platform check.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115832 => 115833)
--- trunk/Tools/ChangeLog 2012-05-02 15:08:03 UTC (rev 115832)
+++ trunk/Tools/ChangeLog 2012-05-02 15:13:35 UTC (rev 115833)
@@ -1,3 +1,18 @@
+2012-05-01 Raphael Kubo da Costa <[email protected]>
+
+ webkitpy: Fix sys.platform check in find_files_unittest.
+ https://bugs.webkit.org/show_bug.cgi?id=85339
+
+ Reviewed by Ryosuke Niwa.
+
+ Follow-up to r101618 -- 'win' is not a valid sys.platform value,
+ 'win32' should be used instead. The check always returned false
+ due to this, so assert_normalize() was never called.
+
+ * Scripts/webkitpy/common/find_files_unittest.py:
+ (TestWinNormalize.test_win): Add the missing import for the
+ FileSystem class and fix the sys.platform check.
+
2012-05-02 Zan Dobersek <[email protected]>
[GTK] drag&drop related failures
Modified: trunk/Tools/Scripts/webkitpy/common/find_files_unittest.py (115832 => 115833)
--- trunk/Tools/Scripts/webkitpy/common/find_files_unittest.py 2012-05-02 15:08:03 UTC (rev 115832)
+++ trunk/Tools/Scripts/webkitpy/common/find_files_unittest.py 2012-05-02 15:13:35 UTC (rev 115833)
@@ -29,6 +29,7 @@
import sys
import unittest
+from webkitpy.common.system.filesystem import FileSystem
import find_files
@@ -55,7 +56,7 @@
def test_win(self):
# This tests the actual windows platform, to ensure we get the same
# results that we get in test_mocked_win().
- if sys.platform != 'win':
+ if sys.platform != 'win32':
return
self.assert_filesystem_normalizes(FileSystem())
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
