Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 408b7bfed729accd26f68780ce1cabbc7e9e4e3a
https://github.com/WebKit/WebKit/commit/408b7bfed729accd26f68780ce1cabbc7e9e4e3a
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/WebCore/style/values/grid/StyleGridTemplateAreas.cpp
Log Message:
-----------
GridTemplateAreas move constructor reads moved-from map, producing empty
implicit named grid lines
https://bugs.webkit.org/show_bug.cgi?id=324515
rdar://187753954
Reviewed by Sam Weinig.
The GridTemplateAreas(GridNamedAreaMap&&) constructor initialized its
`map` member via WTF::move(map), then passed the same `map` parameter —
now moved-from and empty — to initializeImplicitNamedGridLines() for the
implicitNamedGridColumnLines and implicitNamedGridRowLines members. Since
member initializers run in declaration order, `map` (the member) is fully
populated by that point, but the initializer list was reading the emptied
parameter, so both implicit named grid line maps were always built empty.
Read the already-move-initialized `this->map` member instead of the
moved-from parameter. This has been latent since the file was introduced.
* Source/WebCore/style/values/grid/StyleGridTemplateAreas.cpp:
Canonical link: https://commits.webkit.org/321401@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
