Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d00124d9d7903e90b7b4f1a735fb82b025de5b2e
https://github.com/WebKit/WebKit/commit/d00124d9d7903e90b7b4f1a735fb82b025de5b2e
Author: Simon Lewis <[email protected]>
Date: 2026-09-18 (Fri, 18 Sep 2026)
Changed paths:
M Source/cmake/WebKitCommon.cmake
Log Message:
-----------
REGRESSION(321225@main): cmake configure fails on OpenSource-only checkouts
using an internal SDK
https://bugs.webkit.org/show_bug.cgi?id=324558
Reviewed by Zak Ridouh, David Kilzer, and Elliott Williams.
321225@main records the sticky build settings at configure time by running
Tools/Scripts/set-webkit-configuration --cmake under COMMAND_ERROR_IS_FATAL
ANY. set-webkit-configuration goes through webkitdirs.pm, which dies on an
OpenSource-only checkout built against an internal SDK ("Using internal SDK
but unable to find adjacent Internal directory"), so `cmake --preset
mac-asan` now fails at configure on such trees:
CMake Error at Source/cmake/WebKitCommon.cmake:600 (execute_process)
Recording the settings is a convenience for later commands, and this block
already degrades to a status message in its other three can't-record arms
(unresolvable product directory, binary directory outside it, unknown
configuration). Treat a failing set-webkit-configuration the same way: drop
COMMAND_ERROR_IS_FATAL ANY, report the failure as "Not recording the build
settings", and only add the RecordBuildSettings target when the
configure-time recording succeeded — the target reruns the same command on
every build, so without the gate the identical failure moves from the
configure to the first build.
* Source/cmake/WebKitCommon.cmake:
Canonical link: https://commits.webkit.org/321408@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
