Title: [115847] trunk/Source/WebCore
Revision
115847
Author
[email protected]
Date
2012-05-02 10:42:07 -0700 (Wed, 02 May 2012)

Log Message

WebWindowFadeAnimation ignores "duration" parameter. https://bugs.webkit.org/show_bug.cgi?id=85386

Reviewed by Brady Eidson.

Ignoring the "duration" parameter causes the full screen fade and scale animations
to get out of sync.

* platform/mac/WebWindowAnimation.mm:
(-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (115846 => 115847)


--- trunk/Source/WebCore/ChangeLog	2012-05-02 17:17:14 UTC (rev 115846)
+++ trunk/Source/WebCore/ChangeLog	2012-05-02 17:42:07 UTC (rev 115847)
@@ -1,3 +1,16 @@
+2012-05-02  Jer Noble  <[email protected]>
+
+        WebWindowFadeAnimation ignores "duration" parameter.
+        https://bugs.webkit.org/show_bug.cgi?id=85386
+
+        Reviewed by Brady Eidson.
+
+        Ignoring the "duration" parameter causes the full screen fade and scale animations
+        to get out of sync.
+
+        * platform/mac/WebWindowAnimation.mm:
+        (-[WebWindowFadeAnimation initWithDuration:window:initialAlpha:finalAlpha:]):
+
 2012-05-02  Julien Chaffraix  <[email protected]>
 
         REGRESSION(110072): Clipping is not applied on layers that are animated using platform code

Modified: trunk/Source/WebCore/platform/mac/WebWindowAnimation.mm (115846 => 115847)


--- trunk/Source/WebCore/platform/mac/WebWindowAnimation.mm	2012-05-02 17:17:14 UTC (rev 115846)
+++ trunk/Source/WebCore/platform/mac/WebWindowAnimation.mm	2012-05-02 17:42:07 UTC (rev 115847)
@@ -183,13 +183,13 @@
 
 - (id)initWithDuration:(NSTimeInterval)duration window:(NSWindow *)window initialAlpha:(CGFloat)initialAlpha finalAlpha:(CGFloat)finalAlpha
 {
-    UNUSED_PARAM(duration);
     self = [self init];
     if (!self)
         return nil;    
     _window = window;
     _initialAlpha = initialAlpha;
     _finalAlpha = finalAlpha;
+    [self setDuration:duration];
     return self;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to