Skip to site navigation (Press enter)

[webkit-changes] [115849] branches/subpixellayout

leviw Wed, 02 May 2012 10:47:12 -0700

Title: [115849] branches/subpixellayout

Revision: 115849
Author: [email protected]
Date: 2012-05-02 10:48:07 -0700 (Wed, 02 May 2012)

Log Message

Adding skips for overflowing test cases in all platform test_expectations.txt files, and adding parenthesis for FractionalLayoutUnit's overflow message.


Modified Paths

branches/subpixellayout/LayoutTests/platform/chromium/test_expectations.txt
branches/subpixellayout/LayoutTests/platform/efl/test_expectations.txt
branches/subpixellayout/LayoutTests/platform/gtk/test_expectations.txt
branches/subpixellayout/LayoutTests/platform/mac/test_expectations.txt
branches/subpixellayout/LayoutTests/platform/qt/test_expectations.txt
branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h

Diff

Modified: branches/subpixellayout/LayoutTests/platform/chromium/test_expectations.txt (115848 => 115849)


--- branches/subpixellayout/LayoutTests/platform/chromium/test_expectations.txt	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/LayoutTests/platform/chromium/test_expectations.txt	2012-05-02 17:48:07 UTC (rev 115849)
@@ -3705,3 +3705,26 @@
 BUGWK85174 : storage/indexeddb/noblobs.html = TEXT
 
 BUGWK85120 : fast/js/toString-number.html = TEXT
+
+// Assigning negative numbers to unsigned types, triggers stderr in Debug
+BUGWK68744 DEBUG : fast/forms/number/spin-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/select/listbox-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/range/slider-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/single-line.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/clone-block-children-inline-mismatch-crash.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-generated-content.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-property-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-complex-splitting.html = SKIP
+BUGWK68744 DEBUG : fast/block/block-remove-child-delete-line-box-crash.html = SKIP
+
+// Overflowing values cause stderr output in FractionalLayoutUnit in Debug
+BUGWK85303 DEBUG : fast/canvas/canvas-toDataURL-crash.html = SKIP
+BUGWK85303 DEBUG : fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html = SKIP
+BUGWK85303 DEBUG : fast/overflow/overflow-height-float-not-removed-crash3.html = SKIP
+BUGWK85303 DEBUG : fast/selectors/querySelector-in-range-crash.html = SKIP
+BUGWK85303 DEBUG : fast/block/float/no-overhanging-float-crash.html = SKIP

Modified: branches/subpixellayout/LayoutTests/platform/efl/test_expectations.txt (115848 => 115849)


--- branches/subpixellayout/LayoutTests/platform/efl/test_expectations.txt	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/LayoutTests/platform/efl/test_expectations.txt	2012-05-02 17:48:07 UTC (rev 115849)
@@ -290,3 +290,26 @@
 
 // Test doesn't work when the machine is under heavy load.
 BUGWK85180 : media/audio-delete-while-step-button-clicked.html = TEXT PASS
+
+// Assigning negative numbers to unsigned types, triggers stderr in Debug
+BUGWK68744 DEBUG : fast/forms/number/spin-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/select/listbox-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/range/slider-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/single-line.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/clone-block-children-inline-mismatch-crash.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-generated-content.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-property-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-complex-splitting.html = SKIP
+BUGWK68744 DEBUG : fast/block/block-remove-child-delete-line-box-crash.html = SKIP
+
+// Overflowing values cause stderr output in FractionalLayoutUnit in Debug
+BUGWK85303 DEBUG : fast/canvas/canvas-toDataURL-crash.html = SKIP
+BUGWK85303 DEBUG : fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html = SKIP
+BUGWK85303 DEBUG : fast/overflow/overflow-height-float-not-removed-crash3.html = SKIP
+BUGWK85303 DEBUG : fast/selectors/querySelector-in-range-crash.html = SKIP
+BUGWK85303 DEBUG : fast/block/float/no-overhanging-float-crash.html = SKIP

Modified: branches/subpixellayout/LayoutTests/platform/gtk/test_expectations.txt (115848 => 115849)


--- branches/subpixellayout/LayoutTests/platform/gtk/test_expectations.txt	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/LayoutTests/platform/gtk/test_expectations.txt	2012-05-02 17:48:07 UTC (rev 115849)
@@ -1566,6 +1566,29 @@
 BUGWK84776 : ietestcenter/css3/multicolumn/column-width-applies-to-014.htm = IMAGE
 BUGWK84777 : ietestcenter/css3/multicolumn/column-width-applies-to-015.htm = IMAGE
 BUGWK84778 : ietestcenter/css3/multicolumn/column-width-negative-001.htm = IMAGE
+
+// Assigning negative numbers to unsigned types, triggers stderr in Debug
+BUGWK68744 DEBUG : fast/forms/number/spin-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/select/listbox-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/range/slider-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/single-line.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/clone-block-children-inline-mismatch-crash.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-generated-content.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-property-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-complex-splitting.html = SKIP
+BUGWK68744 DEBUG : fast/block/block-remove-child-delete-line-box-crash.html = SKIP
+
+// Overflowing values cause stderr output in FractionalLayoutUnit in Debug
+BUGWK85303 DEBUG : fast/canvas/canvas-toDataURL-crash.html = SKIP
+BUGWK85303 DEBUG : fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html = SKIP
+BUGWK85303 DEBUG : fast/overflow/overflow-height-float-not-removed-crash3.html = SKIP
+BUGWK85303 DEBUG : fast/selectors/querySelector-in-range-crash.html = SKIP
+BUGWK85303 DEBUG : fast/block/float/no-overhanging-float-crash.html = SKIP
 //////////////////////////////////////////////////////////////////////////////////////////
 // End of Tests failing
 //////////////////////////////////////////////////////////////////////////////////////////

Modified: branches/subpixellayout/LayoutTests/platform/mac/test_expectations.txt (115848 => 115849)


--- branches/subpixellayout/LayoutTests/platform/mac/test_expectations.txt	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/LayoutTests/platform/mac/test_expectations.txt	2012-05-02 17:48:07 UTC (rev 115849)
@@ -353,3 +353,26 @@
 
 // Fails after r115379
 BUGWK85038 : http/tests/inspector/network/network-initiator.html = TEXT TIMEOUT
+
+// Assigning negative numbers to unsigned types, triggers stderr in Debug
+BUGWK68744 DEBUG : fast/forms/number/spin-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/select/listbox-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/range/slider-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/single-line.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/clone-block-children-inline-mismatch-crash.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-generated-content.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-property-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-complex-splitting.html = SKIP
+BUGWK68744 DEBUG : fast/block/block-remove-child-delete-line-box-crash.html = SKIP
+
+// Overflowing values cause stderr output in FractionalLayoutUnit in Debug
+BUGWK85303 DEBUG : fast/canvas/canvas-toDataURL-crash.html = SKIP
+BUGWK85303 DEBUG : fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html = SKIP
+BUGWK85303 DEBUG : fast/overflow/overflow-height-float-not-removed-crash3.html = SKIP
+BUGWK85303 DEBUG : fast/selectors/querySelector-in-range-crash.html = SKIP
+BUGWK85303 DEBUG : fast/block/float/no-overhanging-float-crash.html = SKIP

Modified: branches/subpixellayout/LayoutTests/platform/qt/test_expectations.txt (115848 => 115849)


--- branches/subpixellayout/LayoutTests/platform/qt/test_expectations.txt	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/LayoutTests/platform/qt/test_expectations.txt	2012-05-02 17:48:07 UTC (rev 115849)
@@ -59,3 +59,26 @@
 BUGWK85203 : ietestcenter/css3/multicolumn/column-width-applies-to-008.htm = IMAGE
 BUGWK85203 : ietestcenter/css3/multicolumn/column-width-percentage-001.htm = IMAGE
 BUGWK85203 : ietestcenter/css3/multicolumn/column-containing-block-003.htm = IMAGE
+
+// Assigning negative numbers to unsigned types, triggers stderr in Debug
+BUGWK68744 DEBUG : fast/forms/number/spin-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/select/listbox-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/forms/range/slider-in-multi-column.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/single-line.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/clone-block-children-inline-mismatch-crash.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-generated-content.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-dynamic.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-nested-columns-child.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-columns-child-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-property-removal.html = SKIP
+BUGWK68744 DEBUG : fast/multicol/span/span-as-immediate-child-complex-splitting.html = SKIP
+BUGWK68744 DEBUG : fast/block/block-remove-child-delete-line-box-crash.html = SKIP
+
+// Overflowing values cause stderr output in FractionalLayoutUnit in Debug
+BUGWK85303 DEBUG : fast/canvas/canvas-toDataURL-crash.html = SKIP
+BUGWK85303 DEBUG : fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html = SKIP
+BUGWK85303 DEBUG : fast/overflow/overflow-height-float-not-removed-crash3.html = SKIP
+BUGWK85303 DEBUG : fast/selectors/querySelector-in-range-crash.html = SKIP
+BUGWK85303 DEBUG : fast/block/float/no-overhanging-float-crash.html = SKIP

Modified: branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h (115848 => 115849)


--- branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h	2012-05-02 17:45:14 UTC (rev 115848)
+++ branches/subpixellayout/Source/WebCore/platform/FractionalLayoutUnit.h	2012-05-02 17:48:07 UTC (rev 115849)
@@ -46,7 +46,7 @@
 
 #define REPORT_OVERFLOW(doesOverflow) do \
     if (!(doesOverflow)) { \
-        WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, "!%s", #doesOverflow); \
+        WTFReportError(__FILE__, __LINE__, WTF_PRETTY_FUNCTION, "!(%s)", #doesOverflow); \
     } \
 while (0)

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes