Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ed1803f447d76d3373470fca6c7ca0f78ac62eb5
https://github.com/WebKit/WebKit/commit/ed1803f447d76d3373470fca6c7ca0f78ac62eb5
Author: Tim Nguyen <[email protected]>
Date: 2026-09-21 (Mon, 21 Sep 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt
M Source/WebCore/Headers.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/css/CSSCounterStyleDescriptors.cpp
M Source/WebCore/css/CSSCounterStyleDescriptors.h
M Source/WebCore/css/CSSCounterStyleRegistry.cpp
M Source/WebCore/css/CSSRegisteredCounterStyle.cpp
M Source/WebCore/css/CSSRegisteredCounterStyle.h
M Source/WebCore/css/CSSValueKeywords.in
M Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp
M Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp
M Source/WebCore/css/values/content/CSSContent.cpp
M Source/WebCore/css/values/counter-styles/CSSCounterStyle.h
M Source/WebCore/editing/cocoa/FontAttributesCocoa.mm
M Source/WebCore/rendering/RenderListOutsideMarker.cpp
M Source/WebCore/style/values/counter-styles/StyleCounterStyle.cpp
M Source/WebCore/style/values/counter-styles/StyleCounterStyle.h
M Source/WebCore/style/values/lists/StyleListStyleType.cpp
M Source/WebCore/style/values/lists/StyleListStyleType.h
M Source/WebKit/Shared/EditorState.serialization.in
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewGetContents.mm
Log Message:
-----------
[CSS symbols() function] Style & rendering integration
https://bugs.webkit.org/show_bug.cgi?id=324574
rdar://187808030
Reviewed by Sam Weinig.
Add CSS symbols() to the CSS/Style variants and handle the rendering endpoints.
All 10 WPTs for this feature pass after this change.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-lists/parsing/list-style-type-computed-expected.txt:
* Source/WebCore/css/CSSCounterStyleDescriptors.cpp:
(WebCore::CSSCounterStyleDescriptors::createForSymbolsFunction):
(WebCore::systemFromSymbolsTypeKeyword):
(WebCore::symbolsTypeKeywordFromSystem):
(WebCore::CSSCounterStyleDescriptors::areSymbolsValidForSystem):
(WebCore::CSSCounterStyleDescriptors::isValid const):
(WebCore::CSSCounterStyleDescriptors::setSymbols):
(WebCore::CSSCounterStyleDescriptors::setAdditiveSymbols):
* Source/WebCore/css/CSSCounterStyleDescriptors.h:
* Source/WebCore/css/CSSCounterStyleRegistry.cpp:
(WebCore::CSSCounterStyleRegistry::resolvedCounterStyle):
* Source/WebCore/css/CSSRegisteredCounterStyle.cpp:
(WebCore::CSSRegisteredCounterStyle::createForSymbolsFunction):
(WebCore::CSSRegisteredCounterStyle::create):
* Source/WebCore/css/CSSRegisteredCounterStyle.h:
* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/deprecated-cssom/DeprecatedCSSOMPrimitiveValue.cpp:
(WebCore::DeprecatedCSSOMPrimitiveValue::getCounterValue const):
* Source/WebCore/css/parser/CSSPropertyParserConsumer+CounterStyles.cpp:
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedSymbolsType):
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedSymbolsFunction):
(WebCore::CSSPropertyParserHelpers::consumeUnresolvedCounterStyle):
* Source/WebCore/css/values/content/CSSContent.cpp:
(WebCore::CSS::counterStyleForSerialization):
* Source/WebCore/css/values/counter-styles/CSSCounterStyle.h:
* Source/WebCore/editing/cocoa/FontAttributesCocoa.mm:
(WebCore::cocoaTextListMarkerName):
* Source/WebCore/rendering/RenderListOutsideMarker.cpp:
(WebCore::listMarkerTextContent):
* Source/WebCore/style/values/counter-styles/StyleCounterStyle.cpp:
(WebCore::Style::CounterStyle::trySymbolsFunctionCounterStyle const):
(WebCore::Style::keywordFromSymbolsSystem):
(WebCore::Style::symbolsSystemFromKeyword):
(WebCore::Style::ToCSS<CounterStyle>::operator):
(WebCore::Style::ToStyle<CSS::CounterStyle>::operator):
(WebCore::Style::CSSValueCreation<CounterStyle::SymbolsFunction>::operator):
(WebCore::Style::symbolsTypeFromKeywordID):
(WebCore::Style::CSSValueCreation<SymbolsFunction>::operator):
(WebCore::Style::keywordFromSymbolsSystemForSerialization):
* Source/WebCore/style/values/counter-styles/StyleCounterStyle.h:
(WebCore::Style::CounterStyle::CounterStyle):
(WebCore::Style::CounterStyle::tryName const):
(WebCore::Style::CounterStyle::trySymbolsFunction const):
(WebCore::Style::CounterStyle::switchOn const):
(WebCore::Style::CounterStyle::operator== const):
(WebCore::Style::get):
* Source/WebCore/style/values/lists/StyleListStyleType.cpp:
(WebCore::Style::ListStyleType::ListStyleType):
(WebCore::Style::ListStyleType::ipcData const):
(WebCore::Style::ListStyleType::trySymbolsFunctionCounterStyle const):
(WebCore::Style::listStyleTypeFromSymbolsFunction):
(WebCore::Style::CSSValueConversion<ListStyleType>::operator):
(WebCore::Style::CSSValueCreation<ListStyleType>::operator):
(WebCore::Style::ListStyleType::type): Deleted.
(WebCore::Style::ListStyleType::identifier): Deleted.
(): Deleted.
* Source/WebCore/style/values/lists/StyleListStyleType.h:
(WebCore::Style::ListStyleType::ListStyleType):
(WebCore::Style::ListStyleType::isSymbolsFunction const):
(WebCore::Style::ListStyleType::tryCounterStyle const):
(WebCore::Style::ListStyleType::trySymbolsFunction const):
(WebCore::Style::ListStyleType::switchOn const):
* Source/WebKit/Shared/EditorState.serialization.in:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKWebViewGetContents.mm:
(TestWebKitAPI::(WKWebView,
AttributedStringFromListWithSymbolsFunctionListStyleType)):
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/Headers.cmake:
Canonical link: https://commits.webkit.org/321566@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
