Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 32632dc49b191a05b48c091275728a6665f271ab
https://github.com/WebKit/WebKit/commit/32632dc49b191a05b48c091275728a6665f271ab
Author: Chris Dumez <[email protected]>
Date: 2026-09-22 (Tue, 22 Sep 2026)
Changed paths:
M Source/WebKit/Modules/OSX_Private.modulemap
M Source/WebKit/Modules/iOS_Private.modulemap
M Source/WebKit/Platform/cocoa/WKCrashReporter.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Stop exporting WebKit::logAndSetCrashLogMessage as SPI
https://bugs.webkit.org/show_bug.cgi?id=324785
Reviewed by Richard Robinson.
WKCrashReporter.h was installed into WebKit.framework/PrivateHeaders and listed
in the WebKit_Private module maps, so every downstream framework that builds
that module compiled it against whatever WTF the SDK ships. That is what broke
the internal WebInspector build after 321560@main, when the declaration started
naming UTF8CString, a type newer than the SDK's WTF headers.
Nothing outside WebKit calls logAndSetCrashLogMessage, so the header becomes a
project header and the declaration drops WK_EXPORT. With the type no longer
crossing an installed-header boundary, it can name UTF8CString through
wtf/Forward.h again, and the WTF forward declaration added as a build fix goes
away. The __cplusplus guard went with WKBase.h, which only ObjC clients of the
installed header needed.
* Source/WebKit/Modules/OSX_Private.modulemap:
* Source/WebKit/Modules/iOS_Private.modulemap:
* Source/WebKit/Platform/cocoa/WKCrashReporter.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/321657@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
