Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 40a412c4fd1d5ae11d220e5e1b30aefc0bf04aa8
https://github.com/WebKit/WebKit/commit/40a412c4fd1d5ae11d220e5e1b30aefc0bf04aa8
Author: Anne van Kesteren <[email protected]>
Date: 2026-09-23 (Wed, 23 Sep 2026)
Changed paths:
A
LayoutTests/fast/forms/select/base/select-multiple-dropdown-box-picker-expected.txt
A
LayoutTests/fast/forms/select/base/select-multiple-dropdown-box-picker.html
A
LayoutTests/platform/ios/fast/forms/select/base/select-multiple-dropdown-box-picker-expected.txt
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/html/HTMLSelectElement.h
Log Message:
-----------
A multi-select dropdown box should have a base appearance picker
https://bugs.webkit.org/show_bug.cgi?id=324946
Reviewed by Tim Nguyen.
This makes usesBaseAppearancePicker() work with the multiple attribute. This
cannot rely on boxType() yet as that would do the wrong thing when the
preference is disabled on iOS.
Dropping the multiple early return from pickOrToggleOption() is safe as all
callers already checked usesBaseAppearancePicker(). Replaced with an assert.
Test: fast/forms/select/base/select-multiple-dropdown-box-picker.html
Canonical link: https://commits.webkit.org/321698@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
