Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2dc746a367d43ca784477987c28e2ba18965f1c1
https://github.com/WebKit/WebKit/commit/2dc746a367d43ca784477987c28e2ba18965f1c1
Author: Chris Dumez <[email protected]>
Date: 2026-09-23 (Wed, 23 Sep 2026)
Changed paths:
M
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp
M Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm
M Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm
M Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocation.mm
M Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm
M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
M Source/WebKitLegacy/mac/DOM/DOM.mm
M Source/WebKitLegacy/mac/DOM/DOMDocument.mm
M Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm
M Source/WebKitLegacy/mac/History/WebBackForwardList.mm
M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
M Source/WebKitLegacy/mac/Misc/WebCache.mm
M Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
M Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm
M Source/WebKitLegacy/mac/Storage/WebStorageManager.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebOpenPanelResultListener.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm
M Source/WebKitLegacy/mac/WebView/WebArchive.mm
M Source/WebKitLegacy/mac/WebView/WebDataSource.mm
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebResource.mm
M Source/WebKitLegacy/mac/WebView/WebScriptDebugger.mm
M Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm
M Source/WebKitLegacy/mac/WebView/WebTextIterator.mm
M Source/WebKitLegacy/mac/WebView/WebView.mm
Log Message:
-----------
[Safer CPP] Address uncounted arg warnings in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=324937
Reviewed by Rupin Mittal.
* Source/WebKitLegacy/WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::scheduleLoad):
* Source/WebKitLegacy/ios/WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::focusedElementChanged):
* Source/WebKitLegacy/ios/WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame closestCaretRectInMarkedTextRangeForPoint:]):
(-[WebFrame selectionRectsForRange:]):
(-[WebFrame selectionBaseWritingDirection]):
(-[WebFrame setBaseWritingDirection:]):
(-[WebFrame moveSelectionToStart]):
(-[WebFrame moveSelectionToEnd]):
(-[WebFrame startPosition]):
(-[WebFrame endPosition]):
(-[WebFrame renderedCharactersExceed:]):
(-[WebFrame elementRectAtPoint:]):
* Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocation.mm:
(-[WebGeolocation setIsAllowed:]):
* Source/WebKitLegacy/ios/WebCoreSupport/WebVisiblePosition.mm:
(-[DOMHTMLInputElement startPosition]):
(-[DOMHTMLInputElement endPosition]):
(-[DOMHTMLTextAreaElement startPosition]):
(-[DOMHTMLTextAreaElement endPosition]):
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
* Source/WebKitLegacy/mac/DOM/DOM.mm:
(-[DOMNode hrefURL]):
(-[DOMNode hrefTitle]):
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
(-[DOMHTMLLinkElement _mediaQueryMatches]):
* Source/WebKitLegacy/mac/DOM/DOMDocument.mm:
(-[DOMDocument origin]):
* Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm:
(-[DOMRange firstNode]):
(-[DOMHTMLAreaElement boundingBoxWithOwner:]):
(-[DOMHTMLAreaElement absoluteQuadWithOwner:]):
(-[DOMHTMLSelectElement completeLength]):
(-[DOMHTMLSelectElement listItemAtIndex:]):
* Source/WebKitLegacy/mac/History/WebBackForwardList.mm:
(-[WebBackForwardList _close]):
(-[WebBackForwardList addItem:]):
(-[WebBackForwardList removeItem:]):
(-[WebBackForwardList dictionaryRepresentation]):
(-[WebBackForwardList containsItem:]):
(-[WebBackForwardList goToItem:]):
(-[WebBackForwardList backItem]):
(-[WebBackForwardList currentItem]):
(-[WebBackForwardList forwardItem]):
(-[WebBackForwardList backListWithLimit:]):
(-[WebBackForwardList forwardListWithLimit:]):
(-[WebBackForwardList setCapacity:]):
(-[WebBackForwardList backListCount]):
(-[WebBackForwardList forwardListCount]):
(-[WebBackForwardList itemAtIndex:]):
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm:
(-[WebHistoryItem dealloc]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem setAlternateTitle:]):
(-[WebHistoryItem setTitle:]):
(-[WebHistoryItem setViewState:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:]):
* Source/WebKitLegacy/mac/Misc/WebCache.mm:
(+[WebCache imageForURL:]):
* Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm:
(-[WebFrame renderTreeAsExternalRepresentationForPrinting]):
(-[WebFrame renderTreeAsExternalRepresentationWithOptions:]):
(-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
(-[WebFrame printToCGContext:pageWidth:pageHeight:]):
* Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.mm:
(-[WebPluginContainerCheck _isForbiddenFileLoad]):
* Source/WebKitLegacy/mac/Plugins/WebPluginController.mm:
(-[WebPluginController pluginView:receivedResponse:]):
* Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager detailsForDatabase:withOrigin:]):
* Source/WebKitLegacy/mac/Storage/WebStorageManager.mm:
(-[WebStorageManager diskUsageForOrigin:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedElementChanged):
(WebChromeClient::createWindow):
(WebChromeClient::exceededDatabaseQuota):
* Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm:
(WebDragClient::declareAndWriteDragImage):
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm:
(-[WebEditorUndoTarget undoEditing:]):
(-[WebEditorUndoTarget redoEditing:]):
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::forceLayoutOnRestoreFromBackForwardCache):
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebFrameLoaderClient::dispatchCreatePage):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebFrameLoaderClient::createFrame):
(WebFrameLoaderClient::createPlugin):
(WebFrameLoaderClient::createNetworkingContext):
(WebFrameLoaderClient::createHistoryItemTree const):
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationAuditData const):
* Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm:
(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener allow]):
(-[WebGeolocationPolicyListener deny]):
(-[WebGeolocationPolicyListener denyOnlyThisRequest]):
(-[WebGeolocationProviderInitializationListener initializationAllowedWebView:]):
(-[WebGeolocationProviderInitializationListener initializationDeniedWebView:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm:
(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm:
(WebNotificationClient::requestPermission):
(WebNotificationClient::checkPermission):
* Source/WebKitLegacy/mac/WebCoreSupport/WebOpenPanelResultListener.mm:
(-[WebOpenPanelResultListener chooseFilename:]):
(-[WebOpenPanelResultListener chooseFilenames:]):
(-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin host]):
(-[WebSecurityOrigin toString]):
(-[WebSecurityOrigin stringValue]):
(-[WebSecurityOrigin port]):
* Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.mm:
(WebValidationMessageClient::~WebValidationMessageClient):
(WebValidationMessageClient::documentDetached):
(WebValidationMessageClient::showValidationMessage):
(WebValidationMessageClient::updateValidationBubbleStateIfNeeded):
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView layoutSublayers:]):
* Source/WebKitLegacy/mac/WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive data]):
* Source/WebKitLegacy/mac/WebView/WebDataSource.mm:
(-[WebDataSource _addSubframeArchives:]):
(-[WebDataSource _setOverrideTextEncodingName:]):
(-[WebDataSource _documentFragmentWithArchive:]):
(-[WebDataSource _URL]):
(-[WebDataSource _makeRepresentation]):
(-[WebDataSource data]):
(-[WebDataSource isLoading]):
(-[WebDataSource webArchive]):
(-[WebDataSource mainResource]):
(-[WebDataSource subresources]):
(-[WebDataSource subresourceForURL:]):
(-[WebDataSource addSubresource:]):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(getWebView):
(+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
(+[WebFrame _createMainFrameWithSimpleHTMLDocumentWithPage:frameView:style:]):
(-[WebFrame _clearCoreFrame]):
(-[WebFrame _selectedString]):
(-[WebFrame _stringForRange:]):
(-[WebFrame _firstRectForDOMRange:]):
(-[WebFrame _needsLayout]):
(-[WebFrame _convertDOMRangeToNSRange:]):
(-[WebFrame _markDOMRange]):
(-[WebFrame
_replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _visiblePositionForPoint:]):
(-[WebFrame _characterRangeAtPoint:]):
(-[WebFrame _setTypingStyle:withUndoAction:]):
(-[WebFrame _canProvideDocumentSource]):
(-[WebFrame _commitData:]):
(-[WebFrame _pendingFrameUnloadEventCount]):
(-[WebFrame setTimeoutsPaused:]):
(-[WebFrame prepareForPause]):
(-[WebFrame resumeFromPause]):
(-[WebFrame selectWithoutClosingTypingNSRange:]):
(-[WebFrame forceLayoutAdjustingViewSize:]):
(-[WebFrame setNeedsLayout]):
(-[WebFrame preferredHeight]):
(-[WebFrame innerLineHeight:]):
(-[WebFrame caretRect]):
(-[WebFrame rectForScrollToVisible]):
(-[WebFrame caretColor]):
(-[WebFrame setSelectedDOMRange:affinity:closeTyping:userTriggered:]):
(-[WebFrame wordOffsetInRange:]):
(-[WebFrame spaceFollowsWordInRange:]):
(-[WebFrame wordsInCurrentParagraph]):
(-[WebFrame markedTextDOMRange]):
(-[WebFrame setMarkedText:selectedRange:]):
(-[WebFrame setMarkedText:forCandidates:]):
(-[WebFrame confirmMarkedText:]):
(-[WebFrame setText:asChildOfElement:]):
(-[WebFrame setDictationPhrases:metadata:asChildOfElement:]):
(-[WebFrame interpretationsForCurrentRoot]):
(-[WebFrame dictationResultMetadataForRange:]):
(-[WebFrame fontForSelection:]):
(-[WebFrame
_replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
(-[WebFrame removeUnchangeableStyles]):
(-[WebFrame _allowsFollowingLink:]):
(-[WebFrame
_stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
(-[WebFrame setAccessibleName:]):
(-[WebFrame accessibilityRoot]):
(-[WebFrame _clearOpener]):
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]):
(-[WebFrame jsWrapperForNode:inScriptWorld:]):
(-[WebFrame _generateTestReport:withGroup:]):
(-[WebFrame findFrameNamed:]):
(-[WebFrame parentFrame]):
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation receivedData:withDataSource:]):
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
(-[WebHTMLRepresentation elementWithName:inForm:]):
(-[WebHTMLRepresentation
searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView _canEdit]):
(-[WebHTMLView _canEditRichly]):
(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumPageWidth:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView coreCommandBySelector:]):
(-[WebHTMLView coreCommandByName:]):
(-[WebHTMLView reapplyStyles]):
(-[WebHTMLView layout]):
(-[WebHTMLView setNeedsToApplyStyles:]):
(-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
(-[WebHTMLView _web_updateLayoutAndStyleIfNeededRecursive]):
(-[WebHTMLView ALLOW_DEPRECATED_IMPLEMENTATIONS_END]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView insertText:]):
(imageFromRect):
(-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]):
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
(-[WebHTMLView _findString:options:]):
* Source/WebKitLegacy/mac/WebView/WebResource.mm:
(-[WebResource encodeWithCoder:]):
(-[WebResource data]):
(-[WebResource _stringValue]):
* Source/WebKitLegacy/mac/WebView/WebScriptDebugger.mm:
(toWebFrame):
* Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm:
(-[WebScriptWorld unregisterWorld]):
(-[WebScriptWorld dealloc]):
* Source/WebKitLegacy/mac/WebView/WebTextIterator.mm:
(-[WebTextIterator initWithRange:]):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebUITextIndicatorData initWithImage:textIndicator:scale:]):
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _renderTreeSize]):
(-[WebView _close]):
(-[WebView _useDarkAppearance]):
(-[WebView _setUseElevatedUserInterfaceLevel:]):
(-[WebView _setUseDarkAppearance:useElevatedUserInterfaceLevel:]):
(-[WebView setAllowsRemoteInspection:]):
(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView _preferencesChanged:]):
(-[WebView _setMediaLayer:forPluginView:]):
(-[WebView setDefersCallbacks:]):
(-[WebView _setFixedLayoutSize:]):
(-[WebView _synchronizeCustomFixedPositionLayoutRect]):
(-[WebView _executeCoreCommandByName:value:]):
(-[WebView setMemoryCacheDelegateCallsEnabled:]):
(-[WebView _setObscuredTopContentInsetForTesting:right:bottom:left:]):
(+[WebView
_addUserScriptToGroup:world:source:url:includeMatchPatternStrings:excludeMatchPatternStrings:injectionTime:injectedFrames:]):
(+[WebView
_addUserStyleSheetToGroup:world:source:url:includeMatchPatternStrings:excludeMatchPatternStrings:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(-[WebView _scaleWebView:atOrigin:]):
(-[WebView _setIsVisible:]):
(-[WebView _setVisibilityState:isInitialState:]):
(-[WebView viewDidMoveToWindow]):
(-[WebView _updateScreenScaleFromWindow]):
(-[WebView goToBackForwardItem:]):
(-[WebView _invalidateUserAgentCache]):
(incrementFrame):
(-[WebView setGroupName:]):
(-[WebView scheduleInRunLoop:forMode:]):
(-[WebView unscheduleFromRunLoop:forMode:]):
(-[WebView DOMRangeOfString:relativeTo:options:]):
(-[WebView setMediaVolume:]):
(-[WebView suspendAllMediaPlayback]):
(-[WebView resumeAllMediaPlayback]):
(-[WebView editableDOMRangeForPoint:]):
(-[WebView setSelectedDOMRange:affinity:]):
(-[WebView setEditable:]):
(-[WebView deleteSelection]):
(-[WebView applyStyle:]):
(-[WebView insertDictationPhrases:metadata:]):
(-[WebView typingAttributes]):
(-[WebView _simplifyMarkup:endNode:]):
(-[WebView _updateRendering]):
(-[WebView _didCompleteRenderingUpdateDisplay]):
(-[WebView _didCompleteRenderingFrame]):
(-[WebView _flushCompositingChanges]):
(-[WebView _enterVideoFullscreenForVideoElement:mode:]):
Canonical link: https://commits.webkit.org/321734@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
