Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f5d7ec4316e19f7aeaa31d4a27a6842c00bcaebd
https://github.com/WebKit/WebKit/commit/f5d7ec4316e19f7aeaa31d4a27a6842c00bcaebd
Author: Brent Fulgham <[email protected]>
Date: 2026-09-24 (Thu, 24 Sep 2026)
Changed paths:
M Tools/Scripts/build-api-tests
M Tools/Scripts/build-dumprendertree
M Tools/Scripts/build-imagediff
M Tools/Scripts/build-webkittestrunner
M Tools/Scripts/webkitdirs.pm
M Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/base_unittest.py
Log Message:
-----------
Teach run-perf-tests to recognize cmake builds and use them
https://bugs.webkit.org/show_bug.cgi?id=325054
rdar://188225039
Reviewed by Zak Ridouh.
run-perf-tests defaults to --build, which runs build-dumprendertree and
build-webkittestrunner. On Cocoa those always invoke xcodebuild, so a CMake
user gets an Xcode build of the test tools even though webkit-build-directory
has already resolved the CMake tree the tests will run from.
Teach the build-* helper scripts to build their single target with
`cmake --build` when --cmake is passed, or when the configured build system is
CMake and that CMake tree already exists. Otherwise they build with Xcode as
before. DumpRenderTree is skipped when the CMake tree has no such target (it
requires WebKitLegacy), and Xcode build settings like ARCHS=arm64e are dropped
since Ninja would read them as targets.
* Tools/Scripts/build-api-tests:
* Tools/Scripts/build-dumprendertree:
* Tools/Scripts/build-imagediff:
* Tools/Scripts/build-webkittestrunner:
* Tools/Scripts/webkitdirs.pm:
(buildCMakeTarget):
(buildWithExistingCMakeTree):
(ninjaExecutable):
(cmakeBuildHasTarget):
* Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args): Accept --cmake, --xcode and --asan.
* Tools/Scripts/webkitpy/port/base.py:
(Port._arguments_for_configuration): Forward --cmake, --xcode and --asan so the
build-* scripts build the same tree Config.build_directory() resolves.
* Tools/Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_arguments_for_configuration):
Canonical link: https://commits.webkit.org/321816@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
