Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3864134791d72cfa185cfcacada99f882dccd4ae
https://github.com/WebKit/WebKit/commit/3864134791d72cfa185cfcacada99f882dccd4ae
Author: Elliott Williams <[email protected]>
Date: 2026-09-25 (Fri, 25 Sep 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checkers/cmake.py
M Tools/Scripts/webkitpy/style/checkers/cmake_unittest.py
Log Message:
-----------
[check-webkit-style] Fix spurious style checking errors in CMake lists
https://bugs.webkit.org/show_bug.cgi?id=325183
rdar://188318001
Reviewed by Keith Miller and Zak Ridouh.
Fix a few issues in the CMake style checker:
- Lists that terminate on the same line as a variable expansion are now
recognized:
set(x
...
${y})
Previously, the checker would bail out upon seeing the ${} variable
expansion, miss the end of the list, and start diagnosing other syntax
using its list rules.
- Comments are no longer read as list items:
set(x
# inline comment about
y
# and this (extending the above)
z
)
Previously, sorting rules would apply to the text of the comment, and
the parens inside the comment would be treated as terminating the
list.
- Parentheses inside strings were treated as syntax:
if (flag MATCHES "-g($| )?")
Previously, the close-paren inside the string would trigger a `No
space before ")"` violation.
* Tools/Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker._check_list_order):
(CMakeChecker._process_line):
* Tools/Scripts/webkitpy/style/checkers/cmake_unittest.py:
(CMakeCheckerTest.test_check):
Canonical link: https://commits.webkit.org/321942@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
