Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 28a6737f7b7e467239a490a4509b97797178f737
https://github.com/WebKit/WebKit/commit/28a6737f7b7e467239a490a4509b97797178f737
Author: Diego Pino Garcia <[email protected]>
Date: 2026-09-26 (Sat, 26 Sep 2026)
Changed paths:
A
LayoutTests/platform/wpe/fast/events/touch/touch-drag-scrolls-overflow-element-expected.txt
A
LayoutTests/platform/wpe/fast/events/touch/touch-drag-scrolls-overflow-element.html
M Source/WebKit/WPEPlatform/wpe/WPEEvent.cpp
M Source/WebKit/WPEPlatform/wpe/WPEEventInternal.h
M Tools/WebKitTestRunner/wpe/EventSenderProxyClientWPE.cpp
Log Message:
-----------
REGRESSION(318003@main): [WPE] touch gestures sent by WebKitTestRunner are
not recognized
https://bugs.webkit.org/show_bug.cgi?id=325277
Reviewed by Fujii Hironori.
Since 318003@main, WebKitTestRunner creates touch events with
wpeEventTouchCreateForTesting(), which stored the touch points in a
separate WPEEventTouchForTesting variant alternative. The gesture
detector reads touch events with wpe_event_get_position() and
wpe_event_touch_get_sequence_id(), which only handle WPEEventTouch.
wpe_event_get_position() returned false for testing touch events, so no
gesture was recognized: a tap never produced a synthetic click and a
drag never scrolled.
Remove WPEEventTouchForTesting and store all the touch points of a
testing touch event in WPEEventTouch instead, in developer mode only.
wpeEventTouchCreateForTesting() now takes the index of the primary touch
point and stores its sequence ID and position in WPEEventTouch, so the
public accessors work without special cases for testing touch events.
WebKitTestRunner chooses the touch point that changed, or the first one
if none did, as the primary touch point.
Test: platform/wpe/fast/events/touch/touch-drag-scrolls-overflow-element.html
*
LayoutTests/platform/wpe/fast/events/touch/touch-drag-scrolls-overflow-element-expected.txt:
Added.
*
LayoutTests/platform/wpe/fast/events/touch/touch-drag-scrolls-overflow-element.html:
Added.
* Source/WebKit/WPEPlatform/wpe/WPEEvent.cpp:
(wpe_event_get_modifiers):
(wpe_event_touch_new):
(wpeEventTouchCreateForTesting):
(wpeEventIsTouchForTesting):
(wpeEventTouchPointsForTesting):
* Source/WebKit/WPEPlatform/wpe/WPEEventInternal.h:
* Tools/WebKitTestRunner/wpe/EventSenderProxyClientWPE.cpp:
(WTR::EventSenderProxyClientWPE::sendTouchEvent):
Co-Authored-By: Fujii Hironori <[email protected]>, Claude Opus 5.5
Canonical link: https://commits.webkit.org/321980@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
