Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 63810c256dd399217446789508adb2fd0177e88a
https://github.com/WebKit/WebKit/commit/63810c256dd399217446789508adb2fd0177e88a
Author: Simon Fraser <[email protected]>
Date: 2026-09-26 (Sat, 26 Sep 2026)
Changed paths:
M Tools/DumpRenderTree/CMakeLists.txt
M Tools/WebKitTestRunner/CMakeLists.txt
Log Message:
-----------
[cmake] WebKitTestRunner and DumpRenderTree don't see settings coming from
WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=325340
rdar://188443960
Reviewed by Zak Ridouh.
The CMake builds of WebKitTestRunner and DumpRenderTree generated
TestOptionsGeneratedKeys.h from UnifiedWebPreferences.yaml alone, while
the Xcode builds (DerivedSources.make) also include
WebPreferencesAdditions.yaml.
As a result, test-header keys for preferences defined in the additions were
unknown in the CMake build and silently ignored in Release builds, so tests
ran with the default values.
Pass ${WEB_PREFERENCES_ADDITIONS} to GeneratePreferences.rb and depend on
${WEBKITADDITIONS_HEADERS_DEPENDENCIES}, matching Source/WebKit/CMakeLists.txt.
* Tools/DumpRenderTree/CMakeLists.txt:
* Tools/WebKitTestRunner/CMakeLists.txt:
Canonical link: https://commits.webkit.org/321999@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
