Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dfdac830e36dc94a8d86be93e95bf73b6ab4e2cf
https://github.com/WebKit/WebKit/commit/dfdac830e36dc94a8d86be93e95bf73b6ab4e2cf
Author: Dan Hecht <[email protected]>
Date: 2026-09-27 (Sun, 27 Sep 2026)
Changed paths:
M Source/JavaScriptCore/heap/MachineStackMarker.cpp
M Source/JavaScriptCore/heap/MachineStackMarker.h
Log Message:
-----------
[JSC] Rename the conservative scan's "current thread" to the conductor, since
the scan can run on a helper thread
rdar://188434991
https://bugs.webkit.org/show_bug.cgi?id=325325
Reviewed by Yusuke Suzuki and Mark Lam.
The conservative scan called the thread conducting the collection, and the
state it saved
when it stopped, the "current" thread. That is misleading: the scan runs in the
"Cs"
constraint, which any marking thread may pick up, so the current thread is
often a helper,
not the conductor. Name them for the conductor instead, matching Collector's
m_conductorThread and m_conductingMutatorState.
No change in behavior.
* Source/JavaScriptCore/heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromConductor):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):
(JSC::MachineThreads::gatherFromCurrentThread): Deleted.
* Source/JavaScriptCore/heap/MachineStackMarker.h:
Canonical link: https://commits.webkit.org/322007@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
