Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d5fe52e64d81138fd447257c93c5130d24e2c7ef
https://github.com/WebKit/WebKit/commit/d5fe52e64d81138fd447257c93c5130d24e2c7ef
Author: Brady Eidson <[email protected]>
Date: 2026-09-27 (Sun, 27 Sep 2026)
Changed paths:
M Source/WebKit/UIProcess/TextCheckerCompletion.cpp
M Source/WebKit/UIProcess/TextCheckerCompletion.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Spell-checking and proofreading results for a cross-origin
iframe are sent to the main frame's process and dropped
rdar://188484253
https://bugs.webkit.org/show_bug.cgi?id=325375
Reviewed by Anne van Kesteren.
Each of these requests needs to record where the reply is going.
And then needs to route the reply there instead of to the main frame.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/TextCheckerCompletion.cpp:
(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):
(WebKit::TextCheckerCompletion::didFinishCheckingText const):
(WebKit::TextCheckerCompletion::didCancelCheckingText const):
* Source/WebKit/UIProcess/TextCheckerCompletion.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestCheckingOfString):
(WebKit::WebPageProxy::requestExtendedCheckingOfString):
(WebKit::WebPageProxy::didFinishCheckingText): Deleted.
(WebKit::WebPageProxy::didCancelCheckingText): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.h:
* Tools/TestWebKitAPI/Helpers/cocoa/SiteIsolationTestUtilities.mm:
(TestWebKitAPI::webViewWithFocusedCrossOriginIframe):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::swizzledRequestGrammarCheckingDeferringCompletion):
(TestWebKitAPI::extendedProofreadingReplyTriggersRecheck):
(TestWebKitAPI::TEST(SiteIsolation,
ExtendedProofreadingReplyReachesCrossOriginIframe)):
Canonical link: https://commits.webkit.org/322027@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
