Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 181ce41baa059476ef93b443262516d5d127e436
https://github.com/WebKit/WebKit/commit/181ce41baa059476ef93b443262516d5d127e436
Author: Ahmad Saleem <[email protected]>
Date: 2026-09-28 (Mon, 28 Sep 2026)
Changed paths:
M Source/WebCore/dom/Element.cpp
Log Message:
-----------
Element::setElementsArrayAttribute() calls AXObjectCache::updateRelations()
redundantly in a loop
https://bugs.webkit.org/show_bug.cgi?id=324662
rdar://187924948
Reviewed by Chris Dumez.
setElementsArrayAttribute() looped over the elements vector and called
AXObjectCache::updateRelations(*this, attributeName) once per element,
even though every call passed identical arguments (*this and
attributeName) — the loop variable was never used, as its own FIXME
noted. For an N-element array this issued N identical updateRelations()
calls instead of one, and the `for (auto element : ...)` iteration
copied a Ref<Element> (ref-count churn) on each pass.
Collapse the loop to the single call that its sibling
setElementAttribute() already makes.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::setElementsArrayAttribute):
Canonical link: https://commits.webkit.org/322038@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
