Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a5815bc9797a10279ebe7b5fa737ec39e0860b65
https://github.com/WebKit/WebKit/commit/a5815bc9797a10279ebe7b5fa737ec39e0860b65
Author: Claudio Saavedra <[email protected]>
Date: 2026-09-28 (Mon, 28 Sep 2026)
Changed paths:
M Source/JavaScriptCore/API/glib/JSCClass.cpp
M Source/WebDriver/glib/SessionHostGlib.cpp
M Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp
M Source/WebKit/Shared/glib/WebContextMenuItemGlib.cpp
M Source/WebKit/Shared/glib/WebKitContextMenuGAction.cpp
M Source/WebKit/Shared/glib/WebKitContextMenuGAction.h
M Source/WebKit/UIProcess/API/gtk/DragSourceGtk4.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
M Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp
M Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorHTTPServer.cpp
M Source/WebKit/UIProcess/Inspector/wpe/WebInspectorUIProxyWPE.cpp
M Source/WebKit/UIProcess/Notifications/glib/NotificationService.cpp
Log Message:
-----------
[GLib] Compose C strings with makeString() instead of g_strdup_printf() where
the inputs are already WTF strings
https://bugs.webkit.org/show_bug.cgi?id=325403
Reviewed by Carlos Garcia Campos.
Ten places built a string with g_strdup_printf() from a String or a typed
CString, unwrapping each input with legacyCStringPointer() and holding the
result in a GUniquePtr<char> only to read it back as a pointer. makeString()
takes the WTF strings as they are, and utf8() on its result is the typed C
string the following GLib or C call needs.
The WebDriver session host keeps the inspector address as a UTF8CString, which
the RELEASE_LOG macros accept directly, and the context menu GAction name and
the inspector HTTP server address are composed the same way. The inspector
server address never needed a C string at all: it is only ever turned into a
String.
No behavior change.
Canonical link: https://commits.webkit.org/322044@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
