Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4224311245a20984c437793fffb401764ebe9e4
https://github.com/WebKit/WebKit/commit/c4224311245a20984c437793fffb401764ebe9e4
Author: Kristian Monsen <[email protected]>
Date: 2026-09-28 (Mon, 28 Sep 2026)
Changed paths:
A
LayoutTests/http/tests/notifications/request-permission-in-sandboxed-top-level-document-expected.txt
A
LayoutTests/http/tests/notifications/request-permission-in-sandboxed-top-level-document.py
A
LayoutTests/ipc/request-notification-permission-null-origin-crash-expected.txt
A LayoutTests/ipc/request-notification-permission-null-origin-crash.html
M Source/WebKit/UIProcess/WebPageProxy.cpp
Log Message:
-----------
Notification.requestPermission() in a sandboxed top level document crashes
the UI process
https://bugs.webkit.org/show_bug.cgi?id=325387
rdar://187774092
Reviewed by Chris Dumez.
A sandboxed document has an opaque origin, and SecurityOriginData::toString()
returns a null
string for every opaque origin, so the web process sends a null
originIdentifier. In the UI
process that turns back into a null SecurityOriginData, which is the empty
value of
HashTraits<SecurityOriginData>, so adding it to
notificationPermissionRequesters trips
HashTable::validateKey's release assert. Skip the insert for a null origin —
there is
nothing useful to remember, since queryPermission() only ever looks up the
origin of a real
document — and let the permission request itself proceed as before,
Test: ipc/request-notification-permission-null-origin-crash.html
*
LayoutTests/http/tests/notifications/request-permission-in-sandboxed-top-level-document-expected.txt:
Added.
*
LayoutTests/http/tests/notifications/request-permission-in-sandboxed-top-level-document.py:
Added.
*
LayoutTests/ipc/request-notification-permission-null-origin-crash-expected.txt:
Added.
* LayoutTests/ipc/request-notification-permission-null-origin-crash.html: Added.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestNotificationPermission):
Canonical link: https://commits.webkit.org/322110@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
