Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 59c3716f07dcd19c748060a8380211969ad78402
      
https://github.com/WebKit/WebKit/commit/59c3716f07dcd19c748060a8380211969ad78402
  Author: Alan Baradlay <[email protected]>
  Date:   2026-10-01 (Thu, 01 Oct 2026)

  Changed paths:
    A LayoutTests/fast/text/text-removal-after-abspos-br-crash-expected.txt
    A LayoutTests/fast/text/text-removal-after-abspos-br-crash.html
    M LayoutTests/platform/ios/TestExpectations
    M 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp

  Log Message:
  -----------
  REGRESSION(316922@main): [ iOS ] fast/text/out-of-flow-line-break-crash.html 
is a constant failure (CRASH)
https://bugs.webkit.org/show_bug.cgi?id=325017
<rdar://problem/188216504>

Reviewed by Simon Fraser.

  <div><br style="position: absolute">text</div>

Removing "text" should invalidate the first line. Instead we hit 
ASSERT_NOT_REACHED in inlineItemPositionForDamagedContentPosition.

The out-of-flow <br> has an inline item but no display box, so the first 
display box on the line maps to the second inline item.
Removing content from its start looks for an earlier inline item of the same 
layout box and runs into the <br>'s instead.
This only happens on the first line since leading content removal elsewhere 
damages the previous line.

iOS started hitting it in fast/text/out-of-flow-line-break-crash.html at 
316922@main, where keyboard bring-up changed timing and we
started seeing forced layout in the middle of InsertIntoTextNodeCommand.

* LayoutTests/fast/text/text-removal-after-abspos-br-crash-expected.txt: Added.
* LayoutTests/fast/text/text-removal-after-abspos-br-crash.html: Added.
* LayoutTests/platform/ios/TestExpectations:
* 
Source/WebCore/layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp:
(WebCore::Layout::inlineItemPositionForDamagedContentPosition):

Canonical link: https://commits.webkit.org/322377@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to