Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a4c5fcda02c829a07ba3ff6e6dfadfd3d9acf128
https://github.com/WebKit/WebKit/commit/a4c5fcda02c829a07ba3ff6e6dfadfd3d9acf128
Author: Claudio Saavedra <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Tools/Scripts/compare-static-analysis-results
M Tools/Scripts/generate-dirty-files
A Tools/Scripts/webkitpy/safer_cpp/generate_dirty_files_unittest.py
Log Message:
-----------
generate-dirty-files, compare-static-analysis-results: Understand the CMake
build layout
https://bugs.webkit.org/show_bug.cgi?id=325498
Reviewed by Ryosuke Niwa.
CMake builds put the generated JS bindings under WebCore/DerivedSources
instead of DerivedSources/WebCore, keep header copies under
<Project>/Headers, <Project>/PrivateHeaders and
DerivedSources/ForwardingHeaders, name the build directory
WebKitBuild/<Port>/<Configuration>, and record absolute source paths in
the reports. As a result the bindings were reported as regressions
instead of being skipped, header copies showed up under their project
as bare file names, and every file under a checkout whose path contains
a project name (such as WebKit) was attributed to that project,
including ThirdParty headers.
Accept both layouts for the bindings, skip the header copies as Xcode's
already are, strip the CMake build directory prefix, cut absolute paths
back to Source/, name generated files the same way in both layouts, and
skip bug types from checkers the tooling does not know instead of
crashing.
* Tools/Scripts/compare-static-analysis-results:
* Tools/Scripts/generate-dirty-files:
(parse_results_file):
(find_project_results):
* Tools/Scripts/webkitpy/safer_cpp/generate_dirty_files_unittest.py: Added.
(write_report):
(read_files):
(GenerateDirtyFilesTest):
(GenerateDirtyFilesTest.run_script):
(GenerateDirtyFilesTest.test_xcode_layout):
(GenerateDirtyFilesTest.test_cmake_layout):
Canonical link: https://commits.webkit.org/322406@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
