Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bfae3619ae484bda94da4af646dadb7878b31e8c
https://github.com/WebKit/WebKit/commit/bfae3619ae484bda94da4af646dadb7878b31e8c
Author: Brady Eidson <[email protected]>
Date: 2026-10-01 (Thu, 01 Oct 2026)
Changed paths:
M Source/WebCore/editing/cocoa/DictionaryLookup.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Force click and Look Up do nothing over text in cross-origin
iframes
rdar://188925673
https://bugs.webkit.org/show_bug.cgi?id=325972
Reviewed by Alex Christensen.
Hit testing when focus is in a frame in another process is sometimes mishandled.
Fix at least some of those cases.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebCore/editing/cocoa/DictionaryLookup.mm:
(WebCore::DictionaryLookup::rangeAtHitTestResult):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
* Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.mm:
(-[WKWebViewForTestingImmediateActions simulateImmediateAction:]):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::immediateActionWebViewWithCrossOriginIframe):
(TestWebKitAPI::focusCrossOriginIframe):
(TestWebKitAPI::TEST(SiteIsolation,
ImmediateActionInUnfocusedCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
ImmediateActionInCrossOriginIframeDoesNotDispatchForceWillBeginInParent)):
(TestWebKitAPI::TEST(SiteIsolation,
ImmediateActionOffersLookUpInCrossOriginIframe)):
Canonical link: https://commits.webkit.org/322443@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
