Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ecd7191d1410431c643220941bc831d423804122
https://github.com/WebKit/WebKit/commit/ecd7191d1410431c643220941bc831d423804122
Author: Jean-Yves Avenard <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/base_unittest.py
Log Message:
-----------
run-minibrowser and run-swiftbrowser ignore --xcode and --asan
https://bugs.webkit.org/show_bug.cgi?id=326045
rdar://188976906
Reviewed by Elliott Williams.
run-minibrowser --xcode and run-swiftbrowser --xcode ran against the CMake build
when the last build-webkit had recorded CMake, and --asan never selected the
ASan
tree. Port.run_minibrowser() and Port.run_swiftbrowser() rebuilt the arguments
for the Perl scripts themselves and only forwarded the configuration and
--cmake,
so --xcode and --asan never reached webkitdirs.
Both methods now use _arguments_for_configuration(), the same flags
run-webkit-tests passes to the build scripts. A flag given on the command line
selects the build, and without one the settings recorded by the last build are
used.
* Tools/Scripts/webkitpy/port/base.py:
(Port.run_minibrowser): Forward the build selection with
_arguments_for_configuration().
(Port.run_swiftbrowser): Ditto.
* Tools/Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_run_browser_forwards_build_selection): Added.
Canonical link: https://commits.webkit.org/322480@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
