Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 804f13559a360a66e9a1015f3c5f1d0a0bd7ce9b
https://github.com/WebKit/WebKit/commit/804f13559a360a66e9a1015f3c5f1d0a0bd7ce9b
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/gtk.py
M Tools/Scripts/webkitpy/port/wpe.py
Log Message:
-----------
REGRESSION(322476@main) [GTK][WPE] Rendering backend options accidentally
changed the API test environment
https://bugs.webkit.org/show_bug.cgi?id=326071
Reviewed by Carlos Alberto Lopez Perez.
322476@main added the --gl-rendering-backend and --skia-rendering-backend
options, but only run-webkit-tests defines them. The API test runner and
other users of the ports leave them unset, which changed their environment:
WPE API tests lost LIBGL_ALWAYS_SOFTWARE=1 and switched to Skia GPU, and
GTK API tests gained WEBKIT_SKIA_ENABLE_CPU_RENDERING=0. The missing
LIBGL_ALWAYS_SOFTWARE also makes run-wpe-tests crash with a KeyError when
it reaches the WPE Platform tests (see webkit.org/b/326066).
Treat unset options like before 322476@main: WPE uses software GL and
Skia CPU, GTK leaves the environment alone. Layout tests are unaffected
by these changes.
* Tools/Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Tools/Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
Canonical link: https://commits.webkit.org/322490@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
