Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce2ac0b1783dbd9f4897649c6ddb79a5c68dfe3b
https://github.com/WebKit/WebKit/commit/ce2ac0b1783dbd9f4897649c6ddb79a5c68dfe3b
Author: Brady Eidson <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Source/WebKit/Shared/WebHitTestResultData.cpp
M Source/WebKit/Shared/WebHitTestResultData.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/mac/WKImmediateActionController.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.h
M Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Force click previews and highlights vs cross-origin iframes
rdar://188959584
https://bugs.webkit.org/show_bug.cgi?id=326024
Reviewed by Zak Ridouh.
- Previews and highlights are mispositioned in cross-origin iframes
- Force click can fail there if the animation begins before the iframe process
answers
Fixed by translating geometry as needed, and messaging the right frame
processes.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/Shared/WebHitTestResultData.cpp:
(WebKit::WebHitTestResultData::WebHitTestResultData):
(WebKit::WebHitTestResultData::elementBoundingBoxInMainFrameViewCoordinates):
(WebKit::WebHitTestResultData::elementBoundingBoxInWindowCoordinates): Deleted.
* Source/WebKit/Shared/WebHitTestResultData.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performImmediateActionHitTestAtLocation):
(WebKit::WebPageProxy::didPerformImmediateActionHitTest):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::dictionaryPopupInfoForRange):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::remoteDictionaryPopupInfoToRootView): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performImmediateActionHitTestAtLocation):
* Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.h:
* Tools/TestWebKitAPI/Helpers/mac/WKWebViewForTestingImmediateActions.mm:
(-[WKWebViewForTestingImmediateActions
simulateImmediateActionBeginningAnimationImmediately:]):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::TEST(SiteIsolation,
ImmediateActionElementBoundingBoxInCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
ImmediateActionAnimationBeginsBeforeCrossOriginIframeAnswers)):
Canonical link: https://commits.webkit.org/322524@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
