Title: [115962] trunk/Tools
- Revision
- 115962
- Author
- [email protected]
- Date
- 2012-05-03 05:13:23 -0700 (Thu, 03 May 2012)
Log Message
ImageDiff should be run inside a properly established environment
https://bugs.webkit.org/show_bug.cgi?id=85292
Reviewed by Martin Robinson.
When creating the ImageDiff server process, pass along a freshly-set-up environment
in which the process should be executed in.
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._start_image_diff_process):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115961 => 115962)
--- trunk/Tools/ChangeLog 2012-05-03 12:08:24 UTC (rev 115961)
+++ trunk/Tools/ChangeLog 2012-05-03 12:13:23 UTC (rev 115962)
@@ -1,3 +1,16 @@
+2012-05-03 Zan Dobersek <[email protected]>
+
+ ImageDiff should be run inside a properly established environment
+ https://bugs.webkit.org/show_bug.cgi?id=85292
+
+ Reviewed by Martin Robinson.
+
+ When creating the ImageDiff server process, pass along a freshly-set-up environment
+ in which the process should be executed in.
+
+ * Scripts/webkitpy/layout_tests/port/webkit.py:
+ (WebKitPort._start_image_diff_process):
+
2012-05-03 Tor Arne Vestbø <[email protected]>
[Qt] Allow the web process and WTR to be paused on startup
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (115961 => 115962)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-03 12:08:24 UTC (rev 115961)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py 2012-05-03 12:13:23 UTC (rev 115962)
@@ -180,7 +180,8 @@
else:
tolerance = 0.1
command = [self._path_to_image_diff(), '--tolerance', str(tolerance)]
- process = server_process.ServerProcess(self, 'ImageDiff', command)
+ environment = self.setup_environ_for_server('ImageDiff')
+ process = server_process.ServerProcess(self, 'ImageDiff', command, environment)
process.write('Content-Length: %d\n%sContent-Length: %d\n%s' % (
len(actual_contents), actual_contents,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
