Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ea49531186e6aff38e635b7c043c325ed2a3fda
https://github.com/WebKit/WebKit/commit/2ea49531186e6aff38e635b7c043c325ed2a3fda
Author: Elliott Williams <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Source/JavaScriptCore/PlatformCocoa.cmake
M Source/ThirdParty/libwebrtc/CMakeLists.txt
M Source/WebKit/PlatformCocoa.cmake
M Source/WebKitLegacy/PlatformCocoa.cmake
M Source/cmake/OptionsCocoa.cmake
Log Message:
-----------
[CMake] Hide Objective-C and Objective-C++ symbols by default on Cocoa
https://bugs.webkit.org/show_bug.cgi?id=325732
Reviewed by Zak Ridouh.
Xcode hides symbols by default in every language (GCC_SYMBOLS_PRIVATE_EXTERN),
but CMake did so only for C and C++, and hid inline functions only in C++. So
every inline function and template instantiation an Objective-C++ file emitted
was an exported weak definition. Align to Xcode's configuration.
One caveat: WebKit keeps default visibility because TestIPC imports
WebKit's IPC serialization code. In Xcode, we build a separate
WebKitPlatform static library to work around this; we'll have to take a
similar approach for CMake.
Also enable dead-stripping in WebKit's Debug builds, matching the
definition of DEAD_CODE_STRIPPING in Xcode. This drops the precompiled
headers' copies of inline functions which call the now-hidden WTF and
WebCore functions.
* Source/JavaScriptCore/PlatformCocoa.cmake:
* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/WebKit/PlatformCocoa.cmake:
* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/cmake/OptionsCocoa.cmake:
Canonical link: https://commits.webkit.org/322555@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
