Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 814cfe09a43cd740a32b60b99b60cd9fedc78618
https://github.com/WebKit/WebKit/commit/814cfe09a43cd740a32b60b99b60cd9fedc78618
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp
M Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp
Log Message:
-----------
[WPE] Restore DRM vblank monitor support for the legacy API
https://bugs.webkit.org/show_bug.cgi?id=326120
Reviewed by Alejandro G. Castro.
The DRM vblank monitor was added for WPE in 268722@main. It stopped
working for the legacy API due to two regressions:
1. 274136@main made DisplayVBlankMonitor::create() fall back to the timer
for display ID 0. The legacy view never sets a display ID, so it always
got the timer since then. Assign a fixed non-zero display ID when creating
the page, so that we get a chance to create the DRM vlank monitor.
2. 303781@main changed the connector loop in the WPE findCrtc() to declare
a new local variable instead of assigning the outer one - shadowing the
outer one -> findCrtc() always failed and a matching connector was leaked.
This went unnoticed because the code was no longer reachable...
With both fixed, the legacy API is driven by the DRM vblank monitor
again instead of a 60 fps timer - and we should be able to handle
non-60 Hz display refresh rates again, even with the legacy API.
* Source/WebKit/UIProcess/API/wpe/WPEWebViewLegacy.cpp:
(WKWPE::ViewLegacy::ViewLegacy):
* Source/WebKit/UIProcess/glib/DisplayVBlankMonitorDRM.cpp:
(WebKit::findCrtc):
Canonical link: https://commits.webkit.org/322562@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
