Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 20538bbae4b8693406dfe6886d0290eefaa713d5
https://github.com/WebKit/WebKit/commit/20538bbae4b8693406dfe6886d0290eefaa713d5
Author: Kiet Ho <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.html
M Source/WebCore/css/CSSProperties.json
M
Source/WebCore/style/computed/StyleComputedStyleProperties+InitialCustomInlines.h
M Source/WebCore/style/values/anchor-position/StylePositionVisibility.h
Log Message:
-----------
[css-anchor-position-1] Initial value of position-visibility should be
anchor-visible
rdar://188939499
https://bugs.webkit.org/show_bug.cgi?id=325988
Reviewed by Elika Etemad.
History lesson: position-visibility used to accept plural keywords
(anchors-visible,
anchors-valid), because it looked at all anchors being used. Then CSSWG changed
it [1]
to only look at the default anchor, and renamed the keywords to singular
(anchor-visible,
anchor-valid). WebKit renamed them and aliased the plural to singular form in
312080@main, but the initial value is still the plural form, so this patch
fixes it to be the singular form.
[1]: https://github.com/w3c/csswg-drafts/issues/10201
Test:
imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-anchor-position/parsing/position-visibility-computed.html:
- Import from WPT. Ideally we should've imported the whole directory, but
there
are some complications to sort out.
* Source/WebCore/css/CSSProperties.json:
*
Source/WebCore/style/computed/StyleComputedStyleProperties+InitialCustomInlines.h:
(WebCore::Style::ComputedStyleProperties::initialPositionVisibility):
* Source/WebCore/style/values/anchor-position/StylePositionVisibility.h:
Canonical link: https://commits.webkit.org/322565@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
