Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 71b89186dc040a09d220dffb9f370649dc20a8fc
https://github.com/WebKit/WebKit/commit/71b89186dc040a09d220dffb9f370649dc20a8fc
Author: Elliott Williams <[email protected]>
Date: 2026-10-02 (Fri, 02 Oct 2026)
Changed paths:
M Source/CMakeLists.txt
M Source/JavaScriptCore/CMakeLists.txt
M Source/JavaScriptCore/Scripts/generate-combined-inspector-json.py
M Source/WebCore/CMakeLists.txt
M Source/WebKit/CMakeLists.txt
M Source/cmake/OptionsCocoa.cmake
M Source/cmake/WebKitFeatures.cmake
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Use Platform.h-derived definitions of some options flags
https://bugs.webkit.org/show_bug.cgi?id=325717
Reviewed by Zak Ridouh.
Some macOS tests are broken because
ENABLE_DEVICE_ORIENTATION, ENABLE_NAVIGATOR_STANDALONE and
ENABLE_WEBDRIVER_BIDI follow the CMake default (OFF) instead of the
value Xcode-based builds use from Platform.h. These options don't need
to have a hard-coded definition at configuration time; remove them from
cmakeconfig.h and make them Platform.h derived.
To support some code generators' usage of these flags, plumb the
FEATURE_AND_PLATFORM_DEFINES file into a few more places.
* Source/CMakeLists.txt:
* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/Scripts/generate-combined-inspector-json.py:
* Source/WebCore/CMakeLists.txt:
* Source/WebKit/CMakeLists.txt:
* Source/cmake/OptionsCocoa.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/WebKitMacros.cmake:
(webkit_generate_platform_feature_defines_file):
Canonical link: https://commits.webkit.org/322569@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
