Title: [115967] trunk/Tools
- Revision
- 115967
- Author
- [email protected]
- Date
- 2012-05-03 06:16:04 -0700 (Thu, 03 May 2012)
Log Message
[Gtk] ImageDiff crashes when it can't open a display
https://bugs.webkit.org/show_bug.cgi?id=85476
Reviewed by Martin Robinson.
Replace gdk_init() initialization call with the g_type_init()
call. GdkPixbufLoader doesn't actually need the current call to be
made and this change will also remove crashes when ImageDiff
is started in an environment without a DISPLAY env.
* DumpRenderTree/gtk/ImageDiff.cpp:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115966 => 115967)
--- trunk/Tools/ChangeLog 2012-05-03 12:40:19 UTC (rev 115966)
+++ trunk/Tools/ChangeLog 2012-05-03 13:16:04 UTC (rev 115967)
@@ -1,5 +1,20 @@
2012-05-03 Zan Dobersek <[email protected]>
+ [Gtk] ImageDiff crashes when it can't open a display
+ https://bugs.webkit.org/show_bug.cgi?id=85476
+
+ Reviewed by Martin Robinson.
+
+ Replace gdk_init() initialization call with the g_type_init()
+ call. GdkPixbufLoader doesn't actually need the current call to be
+ made and this change will also remove crashes when ImageDiff
+ is started in an environment without a DISPLAY env.
+
+ * DumpRenderTree/gtk/ImageDiff.cpp:
+ (main):
+
+2012-05-03 Zan Dobersek <[email protected]>
+
ImageDiff should be run inside a properly established environment
https://bugs.webkit.org/show_bug.cgi?id=85292
Modified: trunk/Tools/DumpRenderTree/gtk/ImageDiff.cpp (115966 => 115967)
--- trunk/Tools/DumpRenderTree/gtk/ImageDiff.cpp 2012-05-03 12:40:19 UTC (rev 115966)
+++ trunk/Tools/DumpRenderTree/gtk/ImageDiff.cpp 2012-05-03 13:16:04 UTC (rev 115967)
@@ -178,7 +178,7 @@
int main(int argc, char* argv[])
{
- gdk_init(&argc, &argv);
+ g_type_init();
GError* error = 0;
GOptionContext* context = g_option_context_new("- compare two image files, printing their percentage difference and the difference image to stdout");
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
