Title: [115970] trunk/Source/WebKit2
Revision
115970
Author
[email protected]
Date
2012-05-03 07:05:41 -0700 (Thu, 03 May 2012)

Log Message

[Qt] Tap-highlight blinks when activated.
https://bugs.webkit.org/show_bug.cgi?id=85481

Patch by Allan Sandfeld Jensen <[email protected]> on 2012-05-03
Reviewed by Kenneth Rohde Christiansen.

Set the opacity on the page-overlay the first time it is requested to be drawn. Otherwiser
it will start fully opaque before fading in.

* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (115969 => 115970)


--- trunk/Source/WebKit2/ChangeLog	2012-05-03 13:35:12 UTC (rev 115969)
+++ trunk/Source/WebKit2/ChangeLog	2012-05-03 14:05:41 UTC (rev 115970)
@@ -1,3 +1,16 @@
+2012-05-03  Allan Sandfeld Jensen  <[email protected]>
+
+        [Qt] Tap-highlight blinks when activated.
+        https://bugs.webkit.org/show_bug.cgi?id=85481
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Set the opacity on the page-overlay the first time it is requested to be drawn. Otherwiser
+        it will start fully opaque before fading in.
+
+        * WebProcess/WebPage/PageOverlay.cpp:
+        (WebKit::PageOverlay::setNeedsDisplay):
+
 2012-05-03  Kenneth Rohde Christiansen  <[email protected]>
 
         Document the QML WebViewExperimental API devicePixelRatio.

Modified: trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp (115969 => 115970)


--- trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp	2012-05-03 13:35:12 UTC (rev 115969)
+++ trunk/Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp	2012-05-03 14:05:41 UTC (rev 115970)
@@ -92,8 +92,11 @@
 
 void PageOverlay::setNeedsDisplay(const IntRect& dirtyRect)
 {
-    if (m_webPage)
+    if (m_webPage) {
+        if (!m_pageOverlayShouldApplyFadeWhenPainting)
+            m_webPage->drawingArea()->setPageOverlayOpacity(m_fractionFadedIn);
         m_webPage->drawingArea()->setPageOverlayNeedsDisplay(dirtyRect);
+    }
 }
 
 void PageOverlay::setNeedsDisplay()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to