Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 03ef98aa45eca99dd03f33db29313a1985c39821
      
https://github.com/WebKit/WebKit/commit/03ef98aa45eca99dd03f33db29313a1985c39821
  Author: Alan Baradlay <[email protected]>
  Date:   2026-10-03 (Sat, 03 Oct 2026)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [line-clamp] ASSERT in RenderTreeNeedsLayoutChecker when clamped content has 
inline-blocks or ruby annotations
https://bugs.webkit.org/show_bug.cgi?id=326169
<rdar://169497013>

Reviewed by Antti Koivisto.

<div style="line-clamp: 1">Line 1<br><span style="display: 
inline-flex"><span>Line 2</span></span></div>

The inline-flex box is after the clamp point, so line layout never lays it out, 
nor anything inside it.
Discarded content gets its needs-layout bit cleared, but only on the boxes of 
the inline formatting context,
which leaves the content of the inline-flex box needing layout. Clear it there 
too.

* LayoutTests/TestExpectations: line-clamp-026 (in debug), -027, -028 and -032 
pass now.
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/322599@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to