Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a0357405e8ec9e3b0c3a228ffb0db599fc356c0
https://github.com/WebKit/WebKit/commit/1a0357405e8ec9e3b0c3a228ffb0db599fc356c0
Author: Tyler Wilcock <[email protected]>
Date: 2026-10-03 (Sat, 03 Oct 2026)
Changed paths:
A
LayoutTests/accessibility/detected-form-error-uncolored-message-under-dropdown-expected.txt
A
LayoutTests/accessibility/detected-form-error-uncolored-message-under-dropdown.html
A
LayoutTests/accessibility/isolated-tree/detected-form-error-uncolored-message-under-dropdown-expected.txt
A
LayoutTests/accessibility/isolated-tree/detected-form-error-uncolored-message-under-dropdown.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AXFormActivityMonitor.cpp
Log Message:
-----------
AX Error Detection: A message under a dropdown still on its placeholder is
dropped when it isn't red
https://bugs.webkit.org/show_bug.cgi?id=326208
rdar://189093268
Reviewed by Chris Fleizach.
A message in no error color counts only when it appears right under a field the
user left empty or invalid.
Only a text field could count as empty, so a select still on a "Choose a state"
option looked filled in, and
the message under it was dropped.
Count a select whose chosen option has no value as empty, as HTML treats a
placeholder option. This allows
us to properly recognize error messages for default-value selects.
*
LayoutTests/accessibility/detected-form-error-uncolored-message-under-dropdown-expected.txt:
Added.
*
LayoutTests/accessibility/detected-form-error-uncolored-message-under-dropdown.html:
Added.
*
LayoutTests/accessibility/isolated-tree/detected-form-error-uncolored-message-under-dropdown-expected.txt:
Added.
*
LayoutTests/accessibility/isolated-tree/detected-form-error-uncolored-message-under-dropdown.html:
Added.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/accessibility/AXFormActivityMonitor.cpp:
(WebCore::isEmptyOrInvalid):
Canonical link: https://commits.webkit.org/322617@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
