Title: [115974] trunk
- Revision
- 115974
- Author
- mifen...@rim.com
- Date
- 2012-05-03 08:40:35 -0700 (Thu, 03 May 2012)
Log Message
.: Rename attribute.
[BlackBerry] Add special attribute for alternate selection touch handling.
https://bugs.webkit.org/show_bug.cgi?id=85284
Reviewed by Rob Buis.
* ManualTests/blackberry/selection-touch-override.html:
Source/WebKit/blackberry: [BlackBerry] Add special attribute for alternate selection touch handling.
https://bugs.webkit.org/show_bug.cgi?id=85284
Reviewed by Rob Buis.
Rename the custom attribute and make it a data- attribute.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
Modified Paths
Diff
Modified: trunk/ChangeLog (115973 => 115974)
--- trunk/ChangeLog 2012-05-03 15:15:40 UTC (rev 115973)
+++ trunk/ChangeLog 2012-05-03 15:40:35 UTC (rev 115974)
@@ -1,3 +1,14 @@
+2012-05-03 Mike Fenton <mifen...@rim.com>
+
+ Rename attribute.
+
+ [BlackBerry] Add special attribute for alternate selection touch handling.
+ https://bugs.webkit.org/show_bug.cgi?id=85284
+
+ Reviewed by Rob Buis.
+
+ * ManualTests/blackberry/selection-touch-override.html:
+
2012-05-03 Gyuyoung Kim <gyuyoung....@samsung.com>
[CMAKE] Remove unneeded keyword in WebKitFeatures.cmake
Modified: trunk/ManualTests/blackberry/selection-touch-override.html (115973 => 115974)
--- trunk/ManualTests/blackberry/selection-touch-override.html 2012-05-03 15:15:40 UTC (rev 115973)
+++ trunk/ManualTests/blackberry/selection-touch-override.html 2012-05-03 15:40:35 UTC (rev 115974)
@@ -1,2 +1,2 @@
<br><textarea cols="45" rows="5">Text Area without override attribute select all this text and tap on the selection, context menu should be shown!</textarea>
-<br><textarea cols="45" rows="5" -bb-selection-touchoverride="on">Text Area with override attribute select all this text and tap on the selection, caret should be placed!</textarea>
+<br><textarea cols="45" rows="5" data-blackberry-end-selection-on-touch="on">Text Area with override attribute select all this text and tap on the selection, caret should be placed!</textarea>
Modified: trunk/Source/WebKit/blackberry/ChangeLog (115973 => 115974)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-05-03 15:15:40 UTC (rev 115973)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-05-03 15:40:35 UTC (rev 115974)
@@ -1,3 +1,15 @@
+2012-05-03 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Add special attribute for alternate selection touch handling.
+ https://bugs.webkit.org/show_bug.cgi?id=85284
+
+ Reviewed by Rob Buis.
+
+ Rename the custom attribute and make it a data- attribute.
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
+
2012-04-18 Jon Honeycutt <jhoneyc...@apple.com>
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (115973 => 115974)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-05-03 15:15:40 UTC (rev 115973)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-05-03 15:40:35 UTC (rev 115974)
@@ -827,7 +827,7 @@
return false;
// TODO consider caching this in InputHandler so it is only calculated once per focus.
- DEFINE_STATIC_LOCAL(QualifiedName, selectionTouchOverrideAttr, (nullAtom, "-bb-selection-touchoverride", nullAtom));
+ DEFINE_STATIC_LOCAL(QualifiedName, selectionTouchOverrideAttr, (nullAtom, "data-blackberry-end-selection-on-touch", nullAtom));
Element* element = static_cast<Element*>(focusedNode);
return DOMSupport::elementAttributeState(element, selectionTouchOverrideAttr) == DOMSupport::On;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
