[webkit-changes] [WebKit/WebKit] a8755f: Address Safer C++ static analysis warnings in WebK...

Sun, 04 Oct 2026 00:50:32 -0700 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8755fb056b8fa389e91787f86b8bc5f1919fbce
      
https://github.com/WebKit/WebKit/commit/a8755fb056b8fa389e91787f86b8bc5f1919fbce
  Author: Chris Dumez <[email protected]>
  Date:   2026-10-04 (Sun, 04 Oct 2026)

  Changed paths:
    M Source/WebCore/dom/Event.h
    M Source/WebCore/dom/MutationEvent.h
    M Source/WebCore/dom/ProgressEvent.h
    M Source/WebCore/html/HTMLModElement.h
    M Source/WebCore/html/HTMLPreElement.h
    M Source/WebCore/html/HTMLQuoteElement.h
    M 
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M Source/WebKitLegacy/mac/DOM/DOM.mm
    M Source/WebKitLegacy/mac/DOM/DOMAttr.mm
    M Source/WebKitLegacy/mac/DOM/DOMCDATASection.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSFontFaceRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSImportRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSMediaRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSPageRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSPrimitiveValue.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSStyleRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSStyleSheet.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSUnknownRule.mm
    M Source/WebKitLegacy/mac/DOM/DOMCSSValueList.mm
    M Source/WebKitLegacy/mac/DOM/DOMCharacterData.mm
    M Source/WebKitLegacy/mac/DOM/DOMComment.mm
    M Source/WebKitLegacy/mac/DOM/DOMDocument.mm
    M Source/WebKitLegacy/mac/DOM/DOMDocumentFragment.mm
    M Source/WebKitLegacy/mac/DOM/DOMDocumentType.mm
    M Source/WebKitLegacy/mac/DOM/DOMElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMFile.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTML.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLAnchorElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLAreaElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLBRElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLBaseElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLBaseFontElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLBodyElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLButtonElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLCanvasElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLDListElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLDirectoryElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLDivElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLEmbedElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFieldSetElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFontElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFormElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLFrameSetElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLHRElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLHeadElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLHeadingElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLHtmlElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLIFrameElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLImageElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLLIElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLLabelElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLLegendElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLLinkElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMapElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMarqueeElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMediaElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMenuElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLMetaElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLModElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLOListElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLObjectElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLOptGroupElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLOptionElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLParagraphElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLParamElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLPreElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLQuoteElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLSelectElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLStyleElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableCaptionElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableCellElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableColElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableRowElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTableSectionElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTextAreaElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLTitleElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLUListElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLVideoElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMInternal.mm
    M Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMMouseEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMMutationEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMNode.mm
    M Source/WebKitLegacy/mac/DOM/DOMObject.mm
    M Source/WebKitLegacy/mac/DOM/DOMOverflowEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMProcessingInstruction.mm
    M Source/WebKitLegacy/mac/DOM/DOMProgressEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMText.mm
    M Source/WebKitLegacy/mac/DOM/DOMTextEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMUIEvent.mm
    M Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm
    M Source/WebKitLegacy/mac/DOM/DOMUtility.mm
    M Source/WebKitLegacy/mac/DOM/DOMWheelEvent.mm
    M Source/WebKitLegacy/mac/DOM/ObjCEventListener.h
    M Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm

  Log Message:
  -----------
  Address Safer C++ static analysis warnings in WebKitLegacy's ObjC DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=326041

Reviewed by Anne van Kesteren.

Use downcast<> instead of static_cast<> in the IMPL macros of the ObjC DOM 
bindings,
adding type traits to the few WebCore classes that lacked them, and fix the 
remaining
Safer C++ warnings in Source/WebKitLegacy/mac/DOM. Update the expectations 
accordingly.

* Source/WebCore/dom/Event.h:
* Source/WebCore/dom/MutationEvent.h:
* Source/WebCore/dom/ProgressEvent.h:
* Source/WebCore/html/HTMLModElement.h:
* Source/WebCore/html/HTMLPreElement.h:
* Source/WebCore/html/HTMLQuoteElement.h:
Add type traits.
* Source/WebKitLegacy/mac/DOM/DOMHTMLBaseFontElement.mm:
Downcast to HTMLElement, which is the type created for <basefont>.
* Source/WebKitLegacy/mac/DOM/ObjCEventListener.h:
Add type traits and use dynamicDowncast<>.
* Source/WebKitLegacy/mac/DOM/DOM.mm:
* Source/WebKitLegacy/mac/DOM/DOMElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTML.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLObjectElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTextAreaElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMInternal.mm:
* Source/WebKitLegacy/mac/DOM/DOMNode.mm:
* Source/WebKitLegacy/mac/DOM/DOMObject.mm:
* Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm:
* Source/WebKitLegacy/mac/DOM/DOMUtility.mm:
* Source/WebKitLegacy/mac/DOM/WebDOMOperations.mm:
Use downcast<> / checked_objc_cast<>, protect() and smart pointer locals.
* Source/WebKitLegacy/mac/DOM/DOMAttr.mm:
* Source/WebKitLegacy/mac/DOM/DOMCDATASection.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSFontFaceRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSImportRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSMediaRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSPageRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSPrimitiveValue.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSStyleRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSStyleSheet.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSUnknownRule.mm:
* Source/WebKitLegacy/mac/DOM/DOMCSSValueList.mm:
* Source/WebKitLegacy/mac/DOM/DOMCharacterData.mm:
* Source/WebKitLegacy/mac/DOM/DOMComment.mm:
* Source/WebKitLegacy/mac/DOM/DOMDocument.mm:
* Source/WebKitLegacy/mac/DOM/DOMDocumentFragment.mm:
* Source/WebKitLegacy/mac/DOM/DOMDocumentType.mm:
* Source/WebKitLegacy/mac/DOM/DOMFile.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLAnchorElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLAreaElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLBRElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLBaseElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLBodyElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLButtonElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLCanvasElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLDListElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLDirectoryElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLDivElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLDocument.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLEmbedElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLFieldSetElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLFontElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLFormElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLFrameElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLFrameSetElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLHRElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLHeadElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLHeadingElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLHtmlElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLIFrameElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLImageElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLLIElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLLabelElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLLegendElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLLinkElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLMapElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLMarqueeElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLMediaElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLMenuElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLMetaElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLModElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLOListElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLOptGroupElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLOptionElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLParagraphElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLParamElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLPreElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLQuoteElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLScriptElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLSelectElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLStyleElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableCaptionElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableCellElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableColElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableRowElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTableSectionElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLTitleElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLUListElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLVideoElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMKeyboardEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMMouseEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMMutationEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMOverflowEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMProcessingInstruction.mm:
* Source/WebKitLegacy/mac/DOM/DOMProgressEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMText.mm:
* Source/WebKitLegacy/mac/DOM/DOMTextEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMUIEvent.mm:
* Source/WebKitLegacy/mac/DOM/DOMWheelEvent.mm:
Use downcast<> in the IMPL macro.
* Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/322634@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to