Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 00a0acf5827cf00a92eb57e4b5d3d38859a1e6c7
https://github.com/WebKit/WebKit/commit/00a0acf5827cf00a92eb57e4b5d3d38859a1e6c7
Author: Brady Eidson <[email protected]>
Date: 2026-10-04 (Sun, 04 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebPageProxyInternals.h
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Log Message:
-----------
[Site Isolation] Clicking a selection in a cross-origin iframe in a
background window only activates the window
rdar://189060112
https://bugs.webkit.org/show_bug.cgi?id=326175
Reviewed by Anne van Kesteren.
The accepts-first-mouse and window-ordering hit tests always ran in the main
frame's process,
which can't see the content of a cross-origin iframe.
So a click on a selection inside one only activated the window.
Now when the hit lands on a cross-origin iframe, that process replies with the
iframe and the
converted point, and the UI process asks the iframe's process instead.
Test: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::shouldDelayWindowOrderingForEvent):
(WebKit::WebPageProxy::acceptsFirstMouse):
(WebKit::WebPageProxy::handleAcceptsFirstMouse):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::frameForFirstMouseHitTest):
(WebKit::remoteUserInputEventDataForHitInRemoteFrame):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::requestAcceptsFirstMouse):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::inactiveWebViewWithSelectionInFocusedCrossOriginIframe):
(TestWebKitAPI::firstMouseDownEvent):
(TestWebKitAPI::TEST(SiteIsolation,
AcceptsFirstMouseOverSelectionInFocusedCrossOriginIframe)):
(TestWebKitAPI::TEST(SiteIsolation,
ShouldDelayWindowOrderingOverSelectionInFocusedCrossOriginIframe)):
Canonical link: https://commits.webkit.org/322646@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
