[webkit-changes] [WebKit/WebKit] 17d70a: Address Safer C++ static analysis warnings in WebK...

Sun, 04 Oct 2026 22:20:09 -0700 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 17d70acc6670b48e4be4e69e214ab0fa751639f6
      
https://github.com/WebKit/WebKit/commit/17d70acc6670b48e4be4e69e214ab0fa751639f6
  Author: Chris Dumez <[email protected]>
  Date:   2026-10-04 (Sun, 04 Oct 2026)

  Changed paths:
    M Source/WebCore/platform/ios/LegacyTileCache.h
    M Source/WebKitLegacy/PlatformCocoa.cmake
    M Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/NoUncountedMemberCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations
    M 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
    M Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.h
    M Source/WebKitLegacy/mac/WebView/WebArchive.h
    M Source/WebKitLegacy/mac/WebView/WebArchive.mm
    M Source/WebKitLegacy/mac/WebView/WebDataSource.mm
    M Source/WebKitLegacy/mac/WebView/WebDelegateImplementationCaching.mm
    M Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.h
    M Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm
    M Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMockInternal.h
    M Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm
    R Source/WebKitLegacy/mac/WebView/WebFeature.m
    A Source/WebKitLegacy/mac/WebView/WebFeature.mm
    R Source/WebKitLegacy/mac/WebView/WebFormDelegate.m
    A Source/WebKitLegacy/mac/WebView/WebFormDelegate.mm
    M Source/WebKitLegacy/mac/WebView/WebFrame.mm
    M Source/WebKitLegacy/mac/WebView/WebFramePrivate.h
    M Source/WebKitLegacy/mac/WebView/WebFrameView.mm
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.h
    M Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
    M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h
    M Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm
    M Source/WebKitLegacy/mac/WebView/WebIndicateLayer.h
    M Source/WebKitLegacy/mac/WebView/WebIndicateLayer.mm
    M Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm
    M Source/WebKitLegacy/mac/WebView/WebPDFView.h
    M Source/WebKitLegacy/mac/WebView/WebPDFView.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferences.h
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebScriptDebugger.mm
    M Source/WebKitLegacy/mac/WebView/WebTextCompletionController.h
    M Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm
    M Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h
    M Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm
    M Source/WebKitLegacy/mac/WebView/WebViewInternal.h
    M Source/WebKitLegacy/mac/WebView/WebViewPrivate.h
    M Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h

  Log Message:
  -----------
  Address Safer C++ static analysis warnings in WebKitLegacy/mac/WebView
https://bugs.webkit.org/show_bug.cgi?id=326054

Reviewed by Anne van Kesteren.

Fix Safer C++ warnings in Source/WebKitLegacy/mac/WebView and update the
expectations accordingly. WebFeature and WebFormDelegate are renamed to
Objective-C++ so that they can use smart pointers.

* Source/WebKitLegacy/PlatformCocoa.cmake:
* Source/WebKitLegacy/WebKitLegacy.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/mac/WebView/WebFeature.mm: Renamed from 
Source/WebKitLegacy/mac/WebView/WebFeature.m.
* Source/WebKitLegacy/mac/WebView/WebFormDelegate.mm: Renamed from 
Source/WebKitLegacy/mac/WebView/WebFormDelegate.m.
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.h:
Add type traits.
* Source/WebKitLegacy/mac/WebView/WebArchive.h:
* Source/WebKitLegacy/mac/WebView/WebArchive.mm:
* Source/WebKitLegacy/mac/WebView/WebFramePrivate.h:
* Source/WebKitLegacy/mac/WebView/WebPreferences.h:
* Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:
* Source/WebKitLegacy/mac/WebView/WebViewInternal.h:
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:
Declare NSString globals as NSString * const.
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.h:
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm:
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMockInternal.h:
Make m_core const and initialize it with lazyInitialize().
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.h:
* Source/WebKitLegacy/mac/WebView/WebFullScreenController.mm:
* Source/WebKitLegacy/mac/WebView/WebPDFView.h:
* Source/WebKitLegacy/mac/WebView/WebPDFView.mm:
* Source/WebKitLegacy/mac/WebView/WebTextCompletionController.h:
* Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm:
Use RetainPtr for owned instance variables and __weak for non-owning ones.
* Source/WebKitLegacy/mac/WebView/WebIndicateLayer.h:
* Source/WebKitLegacy/mac/WebView/WebIndicateLayer.mm:
* Source/WebKitLegacy/mac/WebView/WebWindowAnimation.h:
Use __weak for non-owning instance variables.
* Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.h:
* Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:
Remove unused instance variables, suppress a MemoryUnsafeCast warning for
WebAVPlayerController, which mimics AVPlayerController without subclassing it,
and use protect() at call sites.
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
(-[WebHTMLView attachRootLayer:]): Read layerHostingView after creating it.
Also use protect(), smart pointer locals and checked Objective-C casts.
* Source/WebKitLegacy/mac/WebView/WebDataSource.mm:
* Source/WebKitLegacy/mac/WebView/WebDelegateImplementationCaching.mm:
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm:
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
* Source/WebKitLegacy/mac/WebView/WebFrameView.mm:
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
* Source/WebKitLegacy/mac/WebView/WebImmediateActionController.mm:
* Source/WebKitLegacy/mac/WebView/WebMediaPlaybackTargetPicker.mm:
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm:
* Source/WebKitLegacy/mac/WebView/WebScriptDebugger.mm:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
Use protect(), smart pointer locals, downcast<> and checked Objective-C casts.
* Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/NoUncountedMemberCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UncheckedLocalVarsCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UncountedLocalVarsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLambdaCapturesCheckerExpectations:
* 
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:

Canonical link: https://commits.webkit.org/322664@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to