Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2c27dbfac62b72c48da70dc1af50310bed9103e
https://github.com/WebKit/WebKit/commit/f2c27dbfac62b72c48da70dc1af50310bed9103e
Author: Ahmad Saleem <[email protected]>
Date: 2026-10-05 (Mon, 05 Oct 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-revert-layer-cascade-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-revert-layer-cascade.html
M Source/WebCore/style/PropertyCascade.cpp
M Source/WebCore/style/PropertyCascade.h
Log Message:
-----------
[css-transitions] revert inside @starting-style drops lower-layer
@starting-style declarations
https://bugs.webkit.org/show_bug.cgi?id=325359
rdar://188463947
Reviewed by Antti Koivisto.
This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.
The rollback cascades built for revert, revert-layer and revert-rule
hardcoded their included property types to normalProperties(), which
does not contain PropertyType::StartingStyle. As a result, addMatch()
dropped every @starting-style declaration from the rollback cascade,
so a revert used inside an @starting-style rule could not roll back to
an @starting-style declaration from a lower priority layer or origin
and instead behaved like "unset".
Propagate the parent cascade's StartingStyle property type into the
rollback cascade so starting-style declarations remain visible during
rollback.
Test:
imported/w3c/web-platform-tests/css/css-transitions/starting-style-revert-layer-cascade.html
*
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-revert-layer-cascade-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/starting-style-revert-layer-cascade.html:
Added.
* Source/WebCore/style/PropertyCascade.cpp:
(WebCore::Style::PropertyCascade::rollbackProperties):
(WebCore::Style::PropertyCascade::PropertyCascade):
* Source/WebCore/style/PropertyCascade.h:
Canonical link: https://commits.webkit.org/322688@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
