Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8f602e03060366c6f67842a4b00498a161d05a4
      
https://github.com/WebKit/WebKit/commit/e8f602e03060366c6f67842a4b00498a161d05a4
  Author: Alex Christensen <[email protected]>
  Date:   2026-10-05 (Mon, 05 Oct 2026)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp
    M Source/WebKit/UIProcess/Automation/BidiScriptAgent.cpp
    M Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h

  Log Message:
  -----------
  Use WebPageProxy::getAllFrames instead of getAllFrameTrees for WebDriver
https://bugs.webkit.org/show_bug.cgi?id=326146
rdar://189043416

Reviewed by BJ Burg.

With site isolation off they do the same thing, getAllFrameTrees would only 
return 1 tree
with all information for LocalFrames.  With site isolation on, though, 
getAllFrameTrees
should only be used for site isolation testing, such as uses of findFramePID 
for finding
which process contains a RemoteFrame, or checkFrameTreesInProcesses, which 
verifies the
frame tree states in all processes used for a single WebPageProxy.

The intent of the use in WebDriver was to get all the info from LocalFrames.

* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _frameTrees:]):
* Source/WebKit/UIProcess/Automation/BidiBrowsingContextAgent.cpp:
(WebKit::BidiBrowsingContextAgent::getNextTree):
* Source/WebKit/UIProcess/Automation/BidiScriptAgent.cpp:
(WebKit::BidiScriptAgent::getRealms):
(WebKit::BidiScriptAgent::processRealmsForPagesAsync):
* Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::emitContextCreatedEvent):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrameTreesForSiteIsolationTesting):
(WebKit::WebPageProxy::getAllFrameTrees): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:

Canonical link: https://commits.webkit.org/322713@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to