Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6b90afd01f7b9b3a65756eac8b6864b1e7e50eca
https://github.com/WebKit/WebKit/commit/6b90afd01f7b9b3a65756eac8b6864b1e7e50eca
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-10-05 (Mon, 05 Oct 2026)
Changed paths:
M Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp
M Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm
Log Message:
-----------
WebGL: Uninitialized heap memory leak via GL_READ_BUFFER desync in
readPixelsForPaintResults
https://bugs.webkit.org/show_bug.cgi?id=317737
rdar://178474070
Reviewed by Dan Glastonbury.
Reset the read buffer for the default framebuffer if client has changed it.
Test: Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm
* Source/WebCore/platform/graphics/angle/ANGLEUtilities.cpp:
(WebCore::ScopedReadBuffer::ScopedReadBuffer):
(WebCore::ScopedReadBuffer::~ScopedReadBuffer):
* Source/WebCore/platform/graphics/angle/ANGLEUtilities.h:
* Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLANGLE::readPixelsForPaintResults):
* Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm:
(TestWebKitAPI::TEST_F(GraphicsContextGLCocoaTest,
CopyNativeImageWithReadBufferNoneWebGL2)):
Originally-landed-as: 316606.99@safari-7625-branch (69788e40ae06).
rdar://187507227
Canonical link: https://commits.webkit.org/322722@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
