Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 56a4f08211a1046a2f93fc4441419412fa2ca837
https://github.com/WebKit/WebKit/commit/56a4f08211a1046a2f93fc4441419412fa2ca837
Author: Devin Rousso <[email protected]>
Date: 2026-10-05 (Mon, 05 Oct 2026)
Changed paths:
M
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js
M
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js
M Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js
M Source/WebInspectorUI/UserInterface/Views/LogContentView.js
M Source/WebInspectorUI/UserInterface/Views/QuickConsole.js
Log Message:
-----------
Web Inspector: Frame selector popup disappears when paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=323101
Reviewed by Timothy Hatcher.
Previously, the execution context picker was hidden when paused as the selected
call frame was used instead.
This unnecessarily limits developers to only evaluating in execution contexts
and/or call frames that are shown in the Sources Tab.
For example, a `Worker` may show "Idle" instead of any call frames, meaning
there's no way for a developer to evaluate anything there.
Instead, expand the "Auto" execution context to also account for the selected
call frame when paused.
This way, developers can evaluate in other execution contexts even without a
corresponding call frame.
* Source/WebInspectorUI/UserInterface/Views/QuickConsole.js:
(WI.QuickConsole):
(WI.QuickConsole.prototype._displayNameForExecutionContext):
(WI.QuickConsole.prototype._displayNameForCallFrame): Added.
(WI.QuickConsole.prototype._resolveDesiredActiveExecutionContext):
(WI.QuickConsole.prototype._setActiveExecutionContext):
(WI.QuickConsole.prototype._updateActiveExecutionContextDisplay):
(WI.QuickConsole.prototype._populateActiveExecutionContextNavigationItemContextMenu):
(WI.QuickConsole.prototype._handleEngineeringShowInternalExecutionContextsSettingChanged):
(WI.QuickConsole.prototype._handleFramePageExecutionContextChanged):
(WI.QuickConsole.prototype._handleFrameExecutionContextsCleared):
(WI.QuickConsole.prototype._handleTargetRemoved):
(WI.QuickConsole.prototype._handleInspectedNodeChanged):
(WI.QuickConsole.prototype._canUseExecutionContextOfInspectedNode): Deleted.
* Source/WebInspectorUI/UserInterface/Controllers/RuntimeManager.js:
(WI.RuntimeManager):
(WI.RuntimeManager.prototype.get useActiveCallFrame): Added.
(WI.RuntimeManager.prototype.set useActiveCallFrame): Added.
(WI.RuntimeManager.prototype.evaluateInInspectedWindow):
(WI.RuntimeManager.prototype.saveResult):
Expose a flag for whether the `activeCallFrame` (if any) is used instead of the
`activeExecutionContext`.
*
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptLogViewController.js:
(WI.JavaScriptLogViewController.prototype.consolePromptShouldCommitText):
* Source/WebInspectorUI/UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.didAppendConsoleMessageView):
*
Source/WebInspectorUI/UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WI.JavaScriptRuntimeCompletionProvider):
(WI.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded):
Use the selected call frame if the developer has selected the "Auto" execution
context.
Canonical link: https://commits.webkit.org/322739@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
