Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d3908003b4f50e48e41b7805f2fbb01eb4668b00
https://github.com/WebKit/WebKit/commit/d3908003b4f50e48e41b7805f2fbb01eb4668b00
Author: Alan Baradlay <[email protected]>
Date: 2026-10-05 (Mon, 05 Oct 2026)
Changed paths:
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderLayoutState.cpp
M Source/WebCore/rendering/RenderLayoutState.h
Log Message:
-----------
[cleanup] Rename IntrinsicLogicalHeightComputationScope to
OrthogonalIntrinsicContributionLayoutScope
https://bugs.webkit.org/show_bug.cgi?id=326042
<rdar://problem/188970306>
Reviewed by Antti Koivisto.
IntrinsicLogicalHeightComputationScope marks an orthogonal box laid out only to
give its container an intrinsic inline-size contribution, so its own percentage
min/max-height follows the cyclic percentage rules.
Its name suggested a general intrinsic block-size measurement, the counterpart
of an intrinsic width computation, which it is not.
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::addOrthogonalIntrinsicContributionLayout):
(WebCore::LocalFrameViewLayoutContext::removeOrthogonalIntrinsicContributionLayout):
(WebCore::LocalFrameViewLayoutContext::isInOrthogonalIntrinsicContributionLayout
const):
(WebCore::LocalFrameViewLayoutContext::addIntrinsicLogicalHeightComputationFor):
Deleted.
(WebCore::LocalFrameViewLayoutContext::removeIntrinsicLogicalHeightComputationFor):
Deleted.
(WebCore::LocalFrameViewLayoutContext::isComputingIntrinsicLogicalHeightFor
const): Deleted.
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::computeIntrinsicLogicalHeight):
* Source/WebCore/rendering/RenderLayoutState.cpp:
(WebCore::OrthogonalIntrinsicContributionLayoutScope::OrthogonalIntrinsicContributionLayoutScope):
(WebCore::OrthogonalIntrinsicContributionLayoutScope::~OrthogonalIntrinsicContributionLayoutScope):
(WebCore::IntrinsicLogicalHeightComputationScope::IntrinsicLogicalHeightComputationScope):
Deleted.
(WebCore::IntrinsicLogicalHeightComputationScope::~IntrinsicLogicalHeightComputationScope):
Deleted.
* Source/WebCore/rendering/RenderLayoutState.h:
Canonical link: https://commits.webkit.org/322774@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
