Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 185f118c277843c1cdf4a28bbfec25560109fc28
      
https://github.com/WebKit/WebKit/commit/185f118c277843c1cdf4a28bbfec25560109fc28
  Author: Anuj Panta <[email protected]>
  Date:   2026-10-05 (Mon, 05 Oct 2026)

  Changed paths:
    A 
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-remote-dom-window-expected.txt
    A 
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-remote-dom-window.html
    M Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp

  Log Message:
  -----------
  Web Inspector: [SI] remoteFrameAccessError() assumes the lexical global 
object wraps a LocalDOMWindow
https://bugs.webkit.org/show_bug.cgi?id=325814
rdar://188827090

Reviewed by Qianlang Chen.

JSObject::calculatedClassName uses the object's own realm as the lexical global 
object.
For a RemoteDOMWindow, the resulting access check reaches 
remoteFrameAccessError(), and
activeDOMWindow()'s downcast<LocalDOMWindow> fails. Use dynamicDowncast and 
return an
empty message when the lexical global object isn't a local window.

* 
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-remote-dom-window-expected.txt:
 Added.
* 
LayoutTests/http/tests/site-isolation/inspector/runtime/evaluate-remote-dom-window.html:
 Added.
* Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:
(WebCore::remoteFrameAccessError):

Canonical link: https://commits.webkit.org/322776@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to