Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a3243e0fce247b8e51be890bbd87f74c970ed399
https://github.com/WebKit/WebKit/commit/a3243e0fce247b8e51be890bbd87f74c970ed399
Author: Devin Rousso <[email protected]>
Date: 2026-10-05 (Mon, 05 Oct 2026)
Changed paths:
A LayoutTests/inspector/canvas/webgpu-label-changes-expected.txt
A LayoutTests/inspector/canvas/webgpu-label-changes.html
M Source/JavaScriptCore/inspector/protocol/Canvas.json
M Source/WebCore/Modules/WebGPU/GPUComputePipeline.cpp
M Source/WebCore/Modules/WebGPU/GPUDevice.cpp
M Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp
M Source/WebCore/inspector/InspectorInstrumentation.cpp
M Source/WebCore/inspector/InspectorInstrumentation.h
M Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp
M Source/WebCore/inspector/agents/InspectorCanvasAgent.h
M Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js
M Source/WebInspectorUI/UserInterface/Models/Canvas.js
M Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js
M Source/WebInspectorUI/UserInterface/Protocol/CanvasObserver.js
M Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js
M Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js
M Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js
M Source/WebInspectorUI/UserInterface/Views/ShaderProgramTreeElement.js
Log Message:
-----------
Web Inspector: Graphics: instrument updating WebGPU device/pipeline `label`
https://bugs.webkit.org/show_bug.cgi?id=326310
Reviewed by Mike Wyrzykowski.
`label` is a mutable property of `GPUDevice`, `GPUComputePipeline`, and
`GPURenderPipeline`.
As such, Web Inspector needs to instrument more than just when it's provided at
construction.
* Source/WebCore/Modules/WebGPU/GPUComputePipeline.cpp:
(WebCore::GPUComputePipeline::setLabel):
* Source/WebCore/Modules/WebGPU/GPUDevice.cpp:
(WebCore::GPUDevice::setLabel):
* Source/WebCore/Modules/WebGPU/GPURenderPipeline.cpp:
(WebCore::GPURenderPipeline::setLabel):
* Source/WebCore/inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didChangeWebGPUDeviceLabel): Added.
(WebCore::InspectorInstrumentation::didChangeWebGPUComputePipelineLabel): Added.
(WebCore::InspectorInstrumentation::didChangeWebGPURenderPipelineLabel): Added.
* Source/WebCore/inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didChangeWebGPUDeviceLabelImpl): Added.
(WebCore::InspectorInstrumentation::didChangeWebGPUComputePipelineLabelImpl):
Added.
(WebCore::InspectorInstrumentation::didChangeWebGPURenderPipelineLabelImpl):
Added.
* Source/JavaScriptCore/inspector/protocol/Canvas.json:
* Source/WebCore/inspector/agents/InspectorCanvasAgent.h:
* Source/WebCore/inspector/agents/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didChangeWebGPUDeviceLabel): Added.
(WebCore::InspectorCanvasAgent::didChangeWebGPUComputePipelineLabel): Added.
(WebCore::InspectorCanvasAgent::didChangeWebGPURenderPipelineLabel): Added.
* Source/WebInspectorUI/UserInterface/Protocol/CanvasObserver.js:
(WI.CanvasObserver.prototype.canvasNameChanged): Added.
(WI.CanvasObserver.prototype.programNameChanged): Added.
* Source/WebInspectorUI/UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.canvasNameChanged): Added.
(WI.CanvasManager.prototype.programNameChanged): Added.
(WI.CanvasManager.prototype._programForIdentifier): Added.
* Source/WebInspectorUI/UserInterface/Models/Canvas.js:
(WI.Canvas.prototype.nameChanged): Added.
* Source/WebInspectorUI/UserInterface/Models/ShaderProgram.js:
(WI.ShaderProgram.prototype.nameChanged): Added.
* Source/WebInspectorUI/UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype.layout):
(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype.detached):
* Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WI.CanvasDetailsSidebarPanel.prototype.set canvas):
(WI.CanvasDetailsSidebarPanel.prototype._handleDisplayNameChanged): Added.
* Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:
(WI.CanvasTreeElement):
(WI.CanvasTreeElement.prototype._handleNameChanged): Added.
* Source/WebInspectorUI/UserInterface/Views/ShaderProgramTreeElement.js:
(WI.ShaderProgramTreeElement):
(WI.ShaderProgramTreeElement.prototype._handleNameChanged): ADded.
* LayoutTests/inspector/canvas/webgpu-label-changes.html: Added.
* LayoutTests/inspector/canvas/webgpu-label-changes-expected.txt: Added.
Canonical link: https://commits.webkit.org/322793@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
