Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d73697d9376a9a1c73d6615fc0e97b9d5cf43349
https://github.com/WebKit/WebKit/commit/d73697d9376a9a1c73d6615fc0e97b9d5cf43349
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-href-change-expected.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-href-change.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-insert-target-expected.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-insert-target.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-remove-readd-target-expected.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-remove-readd-target.svg
A
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-target-ref.svg
M LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations
M Source/WebCore/svg/SVGTextPathElement.cpp
Log Message:
-----------
[LBSE] Re-layout <textPath> when its pending target path appears
https://bugs.webkit.org/show_bug.cgi?id=326338
Reviewed by Rob Buis.
When a <textPath> references a missing id, it registers as a pending
resource. Once an element with that id appears, buildPendingResource()
resolves the target, but in LBSE it returned early without invalidating
the renderer, so the text was never laid out along the path.
Request the renderer update via updateSVGRendererForElementChange() for
both engines. RenderTreeUpdater::updateSVGRenderer() already performs the
engine-specific invalidation.
svg/text/adding-id-on-pending-path.html only covers resolving a pending
<textPath> target by setting an id on an existing path. Add reftests that
insert the referenced path, remove and re-add it, and change href to
another existing path.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-href-change-expected.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-href-change.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-insert-target-expected.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-insert-target.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-remove-readd-target-expected.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-remove-readd-target.svg:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/svg/text/reftests/textpath-dynamic-target-ref.svg:
Added.
* LayoutTests/platform/mac-tahoe-wk2-lbse-text/TestExpectations:
* Source/WebCore/svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged):
(WebCore::SVGTextPathElement::buildPendingResource):
Canonical link: https://commits.webkit.org/322884@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
