Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 21bedf0e04eb8080a8d23cd11749e0dbb1674bb3
https://github.com/WebKit/WebKit/commit/21bedf0e04eb8080a8d23cd11749e0dbb1674bb3
Author: Ahmad Saleem <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/dom/DocumentFullscreen.h
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/SelectorQuery.cpp
M Source/WebCore/dom/SelectorQuery.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
Log Message:
-----------
Convert unscoped enums in DocumentFullscreen, Element, and SelectorQuery to
enum class
https://bugs.webkit.org/show_bug.cgi?id=326491
rdar://189273263
Reviewed by Charlie Wolfe.
Convert three unscoped enums to scoped enums with explicit underlying types:
DocumentFullscreen::FullscreenCheckType (bool), the file-local
LegacyCSSOMElementMetricsRoundingStrategy in Element.cpp (bool), and
SelectorDataList::MatchType (uint8_t). All uses are now qualified.
SelectorDataList::MatchType was declared inline with its member
(`mutable enum MatchType { ... } m_matchType;`); it is now a standalone
enum class followed by a separate `mutable MatchType m_matchType;`.
Two goto labels in SelectorDataList::execute() shared their names with
enumerators (MultipleSelectorMatch, CompiledMultipleSelectorMatch); they
are renamed with a `Case` suffix to match the other labels there.
No new tests, no behavior change.
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::fullscreenElementReadyCheck):
* Source/WebCore/dom/DocumentFullscreen.h:
* Source/WebCore/dom/Element.cpp:
(WebCore::convertToNonSubpixelValue):
(WebCore::adjustOffsetForZoomAndSubpixelLayout):
(WebCore::Element::requestFullscreen):
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::SelectorDataList::execute const):
* Source/WebCore/dom/SelectorQuery.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestRestoreFullScreen):
Canonical link: https://commits.webkit.org/322886@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
