Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c081627f05c0b7938c800369a3a36bafc79ef57
https://github.com/WebKit/WebKit/commit/3c081627f05c0b7938c800369a3a36bafc79ef57
Author: Dawn Morningstar <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Tools/Scripts/webkitpy/style/checkers/api_test_expectations.py
M Tools/Scripts/webkitpy/style/checkers/api_test_expectations_unittest.py
M Tools/Scripts/webkitpy/style/filereader.py
M Tools/Scripts/webkitpy/style/filereader_unittest.py
Log Message:
-----------
check-webkit-style reports every TestExpectations/apitests warning when a
patch only deletes lines
https://bugs.webkit.org/show_bug.cgi?id=326540
rdar://189331695
Reviewed by Jonathan Bedard.
TextFileReader recorded a file with only deleted lines as None, the same value
used when a whole file is
checked, so APITestExpectationsChecker reported every warning in
TestExpectations/apitests. Record such a
file as [] instead and keep None for removed files and whole-file checks.
* Tools/Scripts/webkitpy/style/checkers/api_test_expectations.py:
(APITestExpectationsChecker._should_log_warning):
* Tools/Scripts/webkitpy/style/checkers/api_test_expectations_unittest.py:
(ShouldLogWarningTest.test_deletion_only_file_is_skipped):
* Tools/Scripts/webkitpy/style/filereader.py:
(TextFileReader.delete_file):
* Tools/Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.MockProcessor.do_association_check):
(TextFileReaderTest.test_delete_file_records_removed_file_as_none):
(TextFileReaderTest.test_delete_file_records_deletion_only_file_as_empty):
Canonical link: https://commits.webkit.org/322891@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
