Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8fe1b842bd16520048244e627d46dff17eddb3d0
https://github.com/WebKit/WebKit/commit/8fe1b842bd16520048244e627d46dff17eddb3d0
Author: Chris Dumez <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations
M
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations
M Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocation.mm
M Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocationPrivate.h
M Source/WebKitLegacy/mac/DOM/DOMInternal.h
M Source/WebKitLegacy/mac/DOM/DOMInternal.mm
M Source/WebKitLegacy/mac/History/BackForwardList.h
M Source/WebKitLegacy/mac/History/WebBackForwardList.h
M Source/WebKitLegacy/mac/History/WebBackForwardList.mm
M Source/WebKitLegacy/mac/History/WebHistory.h
M Source/WebKitLegacy/mac/History/WebHistory.mm
M Source/WebKitLegacy/mac/History/WebHistoryItem.h
M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
M Source/WebKitLegacy/mac/History/WebHistoryItemInternal.h
M Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.h
M Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.mm
M Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.h
M Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.h
M Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginController.h
M Source/WebKitLegacy/mac/Plugins/WebPluginController.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.h
M Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm
M Source/WebKitLegacy/mac/Plugins/WebPluginPackage.h
M Source/WebKitLegacy/mac/Plugins/WebPluginPackage.mm
M Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.h
M Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOriginPrivate.h
M Source/WebKitLegacy/mac/WebInspector/WebInspector.h
M Source/WebKitLegacy/mac/WebInspector/WebInspector.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.h
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm
M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.h
M Source/WebKitLegacy/mac/WebView/WebArchive.h
M Source/WebKitLegacy/mac/WebView/WebArchive.mm
M Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.h
M Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.mm
M Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.h
M Source/WebKitLegacy/mac/WebView/WebFrame.h
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
M Source/WebKitLegacy/mac/WebView/WebFrameInternal.h
M Source/WebKitLegacy/mac/WebView/WebFrameView.h
M Source/WebKitLegacy/mac/WebView/WebFrameView.mm
M Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.h
M Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.h
M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
M Source/WebKitLegacy/mac/WebView/WebHTMLView.h
M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
M Source/WebKitLegacy/mac/WebView/WebNavigationData.h
M Source/WebKitLegacy/mac/WebView/WebNavigationData.mm
M Source/WebKitLegacy/mac/WebView/WebNotification.h
M Source/WebKitLegacy/mac/WebView/WebNotification.mm
M Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm
M Source/WebKitLegacy/mac/WebView/WebPolicyDelegatePrivate.h
M Source/WebKitLegacy/mac/WebView/WebResource.h
M Source/WebKitLegacy/mac/WebView/WebResource.mm
M Source/WebKitLegacy/mac/WebView/WebScriptDebugDelegate.h
M Source/WebKitLegacy/mac/WebView/WebScriptDebugDelegate.mm
M Source/WebKitLegacy/mac/WebView/WebScriptWorld.h
M Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm
M Source/WebKitLegacy/mac/WebView/WebTextIterator.h
M Source/WebKitLegacy/mac/WebView/WebTextIterator.mm
M Source/WebKitLegacy/mac/WebView/WebView.h
M Source/WebKitLegacy/mac/WebView/WebView.mm
M Source/WebKitLegacy/mac/WebView/WebViewData.h
M Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.h
Log Message:
-----------
Address the remaining Safer C++ static analysis warnings in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=326457
Reviewed by Anne van Kesteren.
Fix the remaining Safer C++ warnings in WebKitLegacy and empty the
corresponding expectations files.
Owning instance variables declared in WebKit-exported headers are moved to
class extensions or @implementation blocks so they can be RetainPtr/RefPtr.
Non-owning back pointers become __weak.
WebPluginContainerCheck also passed a nil decision listener to the policy
delegate because the listener was copied into a local before it was created.
* Source/WebKitLegacy/SaferCPPExpectations/ForwardDeclCheckerExpectations:
* Source/WebKitLegacy/SaferCPPExpectations/MemoryUnsafeCastCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/NoUnretainedMemberCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/RetainPtrCtorAdoptCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedCallArgsCheckerExpectations:
*
Source/WebKitLegacy/SaferCPPExpectations/UnretainedLocalVarsCheckerExpectations:
* Source/WebKitLegacy/mac/History/WebHistory.h:
* Source/WebKitLegacy/mac/History/WebHistory.mm:
* Source/WebKitLegacy/mac/History/WebHistoryItem.h:
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm:
* Source/WebKitLegacy/mac/History/WebHistoryItemInternal.h:
* Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.h:
* Source/WebKitLegacy/mac/Plugins/WebPluginDatabase.mm:
* Source/WebKitLegacy/mac/WebInspector/WebInspector.h:
* Source/WebKitLegacy/mac/WebInspector/WebInspector.mm:
* Source/WebKitLegacy/mac/WebView/WebArchive.h:
* Source/WebKitLegacy/mac/WebView/WebArchive.mm:
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.h:
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.mm:
* Source/WebKitLegacy/mac/WebView/WebFrame.h:
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
* Source/WebKitLegacy/mac/WebView/WebFrameInternal.h:
* Source/WebKitLegacy/mac/WebView/WebFrameView.h:
* Source/WebKitLegacy/mac/WebView/WebFrameView.mm:
* Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.h:
* Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.mm:
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.h:
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm:
* Source/WebKitLegacy/mac/WebView/WebNavigationData.h:
* Source/WebKitLegacy/mac/WebView/WebNavigationData.mm:
* Source/WebKitLegacy/mac/WebView/WebNotification.h:
* Source/WebKitLegacy/mac/WebView/WebNotification.mm:
* Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm:
* Source/WebKitLegacy/mac/WebView/WebPolicyDelegatePrivate.h:
* Source/WebKitLegacy/mac/WebView/WebResource.h:
* Source/WebKitLegacy/mac/WebView/WebResource.mm:
* Source/WebKitLegacy/mac/WebView/WebScriptDebugDelegate.h:
* Source/WebKitLegacy/mac/WebView/WebScriptDebugDelegate.mm:
* Source/WebKitLegacy/mac/WebView/WebScriptWorld.h:
* Source/WebKitLegacy/mac/WebView/WebScriptWorld.mm:
* Source/WebKitLegacy/mac/WebView/WebTextIterator.h:
* Source/WebKitLegacy/mac/WebView/WebTextIterator.mm:
* Source/WebKitLegacy/mac/WebView/WebView.h:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
* Source/WebKitLegacy/mac/WebView/WebViewData.h:
Move the owning ivars out of the exported headers and use RetainPtr.
Make WebInspector's inspected web view, WebScriptCallFramePrivate's global
object, WebWindowVisibilityObserver's view and WebViewPrivate's insertion
pasteboard __weak. Remove the unused WebViewPrivate userStyleSheetLocation
ivar.
* Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocation.mm:
* Source/WebKitLegacy/ios/WebCoreSupport/WebGeolocationPrivate.h:
* Source/WebKitLegacy/mac/History/WebBackForwardList.h:
* Source/WebKitLegacy/mac/History/WebBackForwardList.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm:
* Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOriginPrivate.h:
Hold the WebCore object in a RefPtr ivar instead of casting a fake private
pointer type with reinterpret_cast.
* Source/WebKitLegacy/mac/History/BackForwardList.h:
* Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.h:
* Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlighter.h:
* Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.h:
* Source/WebKitLegacy/mac/WebView/WebViewRenderingUpdateScheduler.h:
Make the non-owning back pointers __weak.
* Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.h:
* Source/WebKitLegacy/mac/Plugins/WebBasePluginPackage.mm:
* Source/WebKitLegacy/mac/Plugins/WebPluginPackage.h:
* Source/WebKitLegacy/mac/Plugins/WebPluginPackage.mm:
Use RetainPtr for owned instance variables.
* Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.h:
* Source/WebKitLegacy/mac/Plugins/WebPluginContainerCheck.mm:
Use RetainPtr for owned instance variables, and create the decision listener
before copying it into a local.
* Source/WebKitLegacy/mac/Plugins/WebPluginController.h:
* Source/WebKitLegacy/mac/Plugins/WebPluginController.mm:
Use RetainPtr for owned instance variables, including a
RetainPtr<CFMutableSetRef> for the non-retaining checks set, and __weak for
the document view and data source.
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.h:
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm:
Make the highlight view owning on iOS and __weak on macOS, matching the
existing ownership. Make WebHighlightLayer's back pointers __weak.
* Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.h:
* Source/WebKitLegacy/mac/Panels/WebAuthenticationPanel.mm:
Make the outlets __weak and keep the nib's top-level objects alive via
-loadNibNamed:owner:topLevelObjects:.
* Source/WebKitLegacy/mac/WebView/WebHTMLView.h:
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm:
Move _private to a class extension. Pass the Darwin notify center through
protect(), and pass the ASCII-capable input sources through a helper.
* Source/WebKitLegacy/mac/DOM/DOMInternal.h:
* Source/WebKitLegacy/mac/DOM/DOMInternal.mm:
Key the DOM wrapper cache by void* so that callers don't pass the
forward-declared DOMObjectInternal type.
Canonical link: https://commits.webkit.org/322904@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
