Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: fb84f8c54e5f766cc38777ae47830585823b88aa
https://github.com/WebKit/WebKit/commit/fb84f8c54e5f766cc38777ae47830585823b88aa
Author: Zak Ridouh <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
Log Message:
-----------
[Site Isolation][macOS] Start Speaking and Quick Note in a cross-site
iframe's context menu use another frame's text
<https://bugs.webkit.org/show_bug.cgi?id=326019>
<rdar://problem/188957507>
Reviewed by Alex Christensen and Charlie Wolfe.
Start Speaking and the Quick Note items in a cross-site iframe's context menu
used the focused frame's selection, so
they spoke or highlighted another frame's text when focus was elsewhere. Send
these requests to the menu's frame and
have the web process use that frame's selection.
Tests: Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm
* Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::createAppHighlightInSelectedRange):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getSelectionOrContentsAsString):
(WebKit::WebPageProxy::contextMenuItemSelected):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getSelectionOrContentsAsString):
(WebKit::WebPage::createAppHighlightInSelectedRange):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation-1.mm:
(TestWebKitAPI::TEST(SiteIsolation, ContextMenuQuickNoteInCrossOriginIframe)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation,
ContextMenuStartSpeakingInCrossOriginFrame)):
Canonical link: https://commits.webkit.org/322941@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
