Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2a13318e194c11978db4b3b552f15dbd0831cc37
https://github.com/WebKit/WebKit/commit/2a13318e194c11978db4b3b552f15dbd0831cc37
Author: Elliott Williams <[email protected]>
Date: 2026-10-06 (Tue, 06 Oct 2026)
Changed paths:
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/output_capture.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/subprocess_unittest.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/output_capture_unittest.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/terminal_unittest.py
M
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/timeout_unittest.py
M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py
Log Message:
-----------
[webkitcorepy] Fix latent bugs found by static analysis
https://bugs.webkit.org/show_bug.cgi?id=326406
Reviewed by Sam Sneddon.
Running mypy over webkitcorepy, in preparation for adding type annotations,
surfaces several bugs in error paths and rarely used code:
- AutoInstall._verify_index referenced an undefined `index` when reporting a
non-200 response, raising NameError instead of the intended error.
- Timeout.Data.__lt__ called .format() on the ValueError rather than on its
message, raising AttributeError instead.
- OutputDuplicate ignored its `loggers` argument and always attached to the
root logger. No callers pass `loggers` today.
- Terminal.Text's *Background attributes were unpacked from the foreground
colors, so Terminal.Text.redBackground was the same as Terminal.Text.red.
- mocks.Subprocess indexed dict_keys when reporting an unexpected keyword
argument, raising an unrelated TypeError on Python 3.
Bump webkitcorepy to 1.0.5.
* Tools/Scripts/libraries/webkitcorepy/setup.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py:
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(AutoInstall._verify_index):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/mocks/subprocess.py:
(Subprocess.CommandRoute.__init__):
(Subprocess.CommandRoute.matches):
(Subprocess.CommandRoute.__call__):
(Subprocess.__init__):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/output_capture.py:
(OutputDuplicate.__init__):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/terminal.py:
(Terminal.Text):
*
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/autoinstall_unittest.py:
(VerifyIndexTest):
(VerifyIndexTest.test_error_response_names_index):
*
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/mocks/subprocess_unittest.py:
(MockSubprocess.test_unexpected_keyword_argument):
*
Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/output_capture_unittest.py:
(OutputDuplicateTest.test_loggers):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/terminal_unittest.py:
(TerminalTests.test_background_colors):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/tests/timeout_unittest.py:
(TimeoutTests.test_timeout_data_invalid_comparison):
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/timeout.py:
(Timeout.Data.__lt__):
Canonical link: https://commits.webkit.org/322949@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
